[U-Boot] GCC 5.2 issue on imx28

[Tom Rini <trini@konsulko.com>]

On Tue, Jul 28, 2015 at 02:39:49PM +0100, M?ns Rullg?rd wrote:

> Otavio Salvador <otavio.salvador@ossystems.com.br> writes:
> 
> > Hello folks,
> >
> > OE-Core is preparing for upgrade to GCC 5.2 as default compiler and
> > mx28 is failing[1] to build with it.
> >
> > 1. http://errors.yoctoproject.org/Errors/Details/13878/
> >
> > I am not a linker guy so could someone shed any light on this?
> 
> There are two errors reports:
> 
> 1. An undefined reference to the symbol "lowlevel_init"
> 2. A complaint about the ".rel.plt" section not being handled by the
>    linker script.
> 
> The second error is probably caused by the first.  A quick grep turns up
> this snippet in arch/arm/cpu/arm926ejs/mxs/mxs.c:
> 
> /* Lowlevel init isn't used on i.MX28, so just have a dummy here */
> inline void lowlevel_init(void) {}
> 
> The semantics for non-static functions declared inline have changed in
> gcc5, causing the above (empty) function not to be emitted as an
> external symbol.
> 
> Since that function is only referenced from start.S, it should not be
> declared inline at all.  This patch should thus fix your problem:
> Tested-by: Otavio Salvador <otavio@ossystems.com.br>
> 
> diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs.c b/arch/arm/cpu/arm926ejs/mxs/mxs.c
> index ef130ae..b1d8721 100644

After a bit re-wording of the commit message, applied to u-boot/master,
thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150813/b1be4463/attachment.sig>