From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Thu, 13 Aug 2015 17:06:08 +0200 Subject: [U-Boot] [patch] break build if it would produce broken binary In-Reply-To: References: <55239264.2050403@denx.de> <20150408120957.GA22895@amd> <20150408134953.GL9524@bill-the-cat> <20150408140634.GB11550@amd> <20150408155338.GP9524@bill-the-cat> <20150408160817.GR9524@bill-the-cat> <20150413124928.GB19441@amd> <20150413125252.GC16702@bill-the-cat> <20150413203826.GA31301@amd> Message-ID: <20150813150608.GA20313@amd> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue 2015-06-02 11:11:35, Simon Glass wrote: > Hi, > > > > > index 43cc494..ae4c21b 100644 > > > > --- a/arch/arm/include/asm/u-boot.h > > > > +++ b/arch/arm/include/asm/u-boot.h > > > > @@ -49,4 +49,8 @@ typedef struct bd_info { > > > > #define IH_ARCH_DEFAULT IH_ARCH_ARM64 > > > > #endif > > > > > > > > +#if defined(CONFIG_USE_PRIVATE_LIBGCC) && defined(CONFIG_SYS_THUMB_BUILD) > > > > +#error Thumb build does not work with private libgcc. > > > > +#endif > > > > + > > > > #endif /* _U_BOOT_H_ */ > > > > > > I'm agreeable to taking this for the release if you'll go and debug > > > what's wrong with our private libgcc code for the next release. > > > > If you are willing to ship u-boot with known and nasty to debug > > problem, it is your choice. > > > > Either the patch is good or it is bad, my future plans should have > > nothing to do with it. Notice that this patch does not help _me_ in > > any way, as I know about the issue and am unlikely to hit it again, > > and that original problem still breaks the build on my system. ... > Pavel, your email seemed to me as a little sharp for the mailing list. Well, I have to survive on the lkml, so I write sharp emails sometimes. Sorry about that. Pavel# (not a typo) -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html