public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb_storage: USB storage transfer size increase for xHCI
Date: Fri, 14 Aug 2015 01:12:36 +0200	[thread overview]
Message-ID: <201508140112.36859.marex@denx.de> (raw)
In-Reply-To: <CAPEA6dYcY=cHgOjFwTC0yagDPqrGOqEi_-BkQ1ODNAe7tSyROw@mail.gmail.com>

On Friday, August 14, 2015 at 12:48:57 AM, Sergei Temerkhanov wrote:

Hi,

please stop top-posting :(

> Well, when I was working on this, setting large transfer sizes resulted in,
> AFAIR, xhci_wait_for_event() timeout and changing XHCI_TIMEOUT doesn't
> help. This function returns NULL which is being dereferenced somewhere else
> (I don't remember where exactly), there are several places in the generic
> xhci support code where this is possible - I think it was abort_td().

Can you please send fixes for those null-pointer dereferences you're triggering?
Also, I suspect that if your controller cannot support arbitrary lenght of the
descriptors, it might be a controller bug and a quirk should be introduced. Does
the controller work in Linux ?

> Regards,
> Sergey
> 
> On Thu, Aug 13, 2015 at 10:34 PM, Marek Vasut <marex@denx.de> wrote:
> > On Thursday, August 13, 2015 at 09:13:52 PM, Sergei Temerkhanov wrote:
> > > Tried different values but transfer sizes larger than ~8k blocks never
> > > complete on some controllers causing timeouts and crashes. So, 4k
> > > blocks
> > 
> > is
> > 
> > > a safe enough xfer size
> > 
> > Would you please elaborate on this ?
> > 
> > Best regards,
> > Marek Vasut

Best regards,
Marek Vasut

      reply	other threads:[~2015-08-13 23:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 19:00 [U-Boot] [PATCH] usb_storage: USB storage transfer size increase for xHCI Sergey Temerkhanov
2015-08-13 19:09 ` Marek Vasut
2015-08-13 19:13   ` Sergei Temerkhanov
2015-08-13 19:34     ` Marek Vasut
     [not found]       ` <CAPEA6dY71DZhHb61c_+RfdvsM0PvzXRxY1nSw9zFPaqvTYzUgQ@mail.gmail.com>
2015-08-13 22:42         ` Marek Vasut
2015-08-14 12:09           ` Sergei Temerkhanov
2015-08-14 12:15             ` Marek Vasut
2015-08-13 22:48       ` Sergei Temerkhanov
2015-08-13 23:12         ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201508140112.36859.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox