From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 14 Aug 2015 01:12:36 +0200 Subject: [U-Boot] [PATCH] usb_storage: USB storage transfer size increase for xHCI In-Reply-To: References: <1439492404-1606-1-git-send-email-s.temerkhanov@gmail.com> <201508132134.23667.marex@denx.de> Message-ID: <201508140112.36859.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, August 14, 2015 at 12:48:57 AM, Sergei Temerkhanov wrote: Hi, please stop top-posting :( > Well, when I was working on this, setting large transfer sizes resulted in, > AFAIR, xhci_wait_for_event() timeout and changing XHCI_TIMEOUT doesn't > help. This function returns NULL which is being dereferenced somewhere else > (I don't remember where exactly), there are several places in the generic > xhci support code where this is possible - I think it was abort_td(). Can you please send fixes for those null-pointer dereferences you're triggering? Also, I suspect that if your controller cannot support arbitrary lenght of the descriptors, it might be a controller bug and a quirk should be introduced. Does the controller work in Linux ? > Regards, > Sergey > > On Thu, Aug 13, 2015 at 10:34 PM, Marek Vasut wrote: > > On Thursday, August 13, 2015 at 09:13:52 PM, Sergei Temerkhanov wrote: > > > Tried different values but transfer sizes larger than ~8k blocks never > > > complete on some controllers causing timeouts and crashes. So, 4k > > > blocks > > > > is > > > > > a safe enough xfer size > > > > Would you please elaborate on this ? > > > > Best regards, > > Marek Vasut Best regards, Marek Vasut