public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tftp: adjust settings to be suitable for 100Mbit ethernet
Date: Tue, 18 Aug 2015 14:34:26 +0200	[thread overview]
Message-ID: <20150818123426.GA4946@amd> (raw)


Adjust timouts and retry counts to be suitable for loaded ethernet
network. With 5 seconds timeout, 10 retries maximum, tftp is
impossible even on local network with single full-speed TCP
connection.

100msec timeout should be suitable for most networks tftp is used on,
that is local ethernets. Timeout count really needs to be way higher,
as lost packets are normal when TCP is running over the same network.

Enforce 10msec minimum. 

Signed-off-by: Pavel Machek <pavel@denx.de>

diff --git a/net/tftp.c b/net/tftp.c
index 0a2c533..c5ea3f2 100644
--- a/net/tftp.c
+++ b/net/tftp.c
@@ -18,10 +18,10 @@
 /* Well known TFTP port # */
 #define WELL_KNOWN_PORT	69
 /* Millisecs to timeout for lost pkt */
-#define TIMEOUT		5000UL
+#define TIMEOUT		100UL
 #ifndef	CONFIG_NET_RETRY_COUNT
 /* # of timeouts before giving up */
-# define TIMEOUT_COUNT	10
+# define TIMEOUT_COUNT	1000
 #else
 # define TIMEOUT_COUNT  (CONFIG_NET_RETRY_COUNT * 2)
 #endif
@@ -703,11 +703,11 @@ void TftpStart(enum proto_t protocol)
 	if (ep != NULL)
 		TftpTimeoutMSecs = simple_strtol(ep, NULL, 10);
 
-	if (TftpTimeoutMSecs < 1000) {
+	if (TftpTimeoutMSecs < 10) {
 		printf("TFTP timeout (%ld ms) too low, "
-			"set minimum = 1000 ms\n",
+			"set minimum = 10 ms\n",
 			TftpTimeoutMSecs);
-		TftpTimeoutMSecs = 1000;
+		TftpTimeoutMSecs = 10;
 	}
 
 	debug("TFTP blocksize = %i, timeout = %ld ms\n",

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

             reply	other threads:[~2015-08-18 12:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18 12:34 Pavel Machek [this message]
2015-08-21 21:19 ` [U-Boot] [PATCH] tftp: adjust settings to be suitable for 100Mbit ethernet Joe Hershberger
2015-08-24 14:48 ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150818123426.GA4946@amd \
    --to=pavel@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox