From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 7/7] sf: Add FSR support to spi_flash_cmd_wait_ready
Date: Wed, 19 Aug 2015 00:03:42 +0200 [thread overview]
Message-ID: <201508190003.42475.marex@denx.de> (raw)
In-Reply-To: <1439807574-26767-8-git-send-email-jteki@openedev.com>
On Monday, August 17, 2015 at 12:32:54 PM, Jagan Teki wrote:
> This patch adds flag status register reading support to
> spi_flash_cmd_wait_ready.
>
> Signed-off-by: Jagan Teki <jteki@openedev.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Tom Warren <twarren@nvidia.com>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Hou Zhiqiang <B48286@freescale.com>
> Tested-by: Jagan Teki <jteki@openedev.com>
> ---
> drivers/mtd/spi/sf_internal.h | 1 +
> drivers/mtd/spi/sf_ops.c | 66
> +++++++++++++++++++++++++++++++++++++++---- drivers/mtd/spi/sf_probe.c
> | 4 +--
> include/spi_flash.h | 2 --
> 4 files changed, 62 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/mtd/spi/sf_internal.h b/drivers/mtd/spi/sf_internal.h
> index e97c716..4ecfd0c 100644
> --- a/drivers/mtd/spi/sf_internal.h
> +++ b/drivers/mtd/spi/sf_internal.h
> @@ -49,6 +49,7 @@ enum {
>
> enum spi_nor_option_flags {
> SNOR_F_SST_WR = (1 << 0),
> + SNOR_F_USE_FSR = (1 << 1),
> };
>
> #define SPI_FLASH_3B_ADDR_LEN 3
> diff --git a/drivers/mtd/spi/sf_ops.c b/drivers/mtd/spi/sf_ops.c
> index 7d7c264..a5487ad 100644
> --- a/drivers/mtd/spi/sf_ops.c
> +++ b/drivers/mtd/spi/sf_ops.c
> @@ -40,6 +40,21 @@ int spi_flash_cmd_read_status(struct spi_flash *flash,
> u8 *rs) return 0;
> }
>
> +static int read_fsr(struct spi_flash *flash, u8 *fsr)
> +{
> + int ret;
> + u8 cmd;
> +
> + cmd = CMD_FLAG_STATUS;
> + ret = spi_flash_read_common(flash, &cmd, 1, fsr, 1);
> + if (ret < 0) {
> + debug("SF: fail to read flag status register\n");
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> int spi_flash_cmd_write_status(struct spi_flash *flash, u8 ws)
> {
> u8 cmd;
> @@ -138,24 +153,63 @@ static void spi_flash_dual_flash(struct spi_flash
> *flash, u32 *addr) }
> #endif
>
> +static inline int spi_flash_sr_ready(struct spi_flash *flash)
> +{
> + u8 sr;
> + int ret;
> +
> + ret = spi_flash_cmd_read_status(flash, &sr);
> + if (ret < 0)
> + return ret;
> +
> + if (sr < 0)
Have you ever seen u8 value that's < 0 ? :-)
> + return sr;
> + else
> + return !(sr & STATUS_WIP);
> +}
[...]
next prev parent reply other threads:[~2015-08-18 22:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 10:32 [U-Boot] [PATCH v2 0/7] BAR/wait_ready logic updates Jagan Teki
2015-08-17 10:32 ` [U-Boot] [PATCH v2 1/7] spi: zynq_spi: Remove unneeded headers Jagan Teki
2015-08-17 10:32 ` [U-Boot] [PATCH v2 2/7] sf: Return proper bank_sel, if flash->bank_curr == bank_sel Jagan Teki
2015-08-17 10:32 ` [U-Boot] [PATCH v2 3/7] sf: Make BAR discovery, as spi_flash_read_bar Jagan Teki
2015-08-18 7:46 ` Bin Meng
2015-08-18 8:22 ` Jagan Teki
2015-08-17 10:32 ` [U-Boot] [PATCH v2 4/7] sf: Optimize BAR write code Jagan Teki
2015-08-17 10:32 ` [U-Boot] [PATCH v2 5/7] sf: Make flash->flags use for generic usage Jagan Teki
2015-08-18 7:53 ` Bin Meng
2015-08-18 8:31 ` Jagan Teki
2015-08-17 10:32 ` [U-Boot] [PATCH v2 6/7] sf: Update status reg check in spi_flash_cmd_wait_ready Jagan Teki
2015-08-18 22:02 ` Marek Vasut
2015-08-18 22:39 ` Jagan Teki
2015-08-17 10:32 ` [U-Boot] [PATCH v2 7/7] sf: Add FSR support to spi_flash_cmd_wait_ready Jagan Teki
2015-08-18 22:03 ` Marek Vasut [this message]
2015-08-18 22:36 ` Jagan Teki
2015-08-18 22:58 ` Marek Vasut
2015-08-19 7:35 ` Jagan Teki
2015-08-19 7:39 ` Marek Vasut
2015-08-19 8:17 ` Jagan Teki
2015-08-19 20:10 ` Marek Vasut
2015-08-18 4:42 ` [U-Boot] [PATCH v2 0/7] BAR/wait_ready logic updates Bin Meng
2015-08-18 5:22 ` Jagan Teki
2015-08-18 7:12 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201508190003.42475.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox