public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ddr: altera: Replace float multiplication with integer one
Date: Wed, 19 Aug 2015 00:07:26 +0200	[thread overview]
Message-ID: <201508190007.26717.marex@denx.de> (raw)
In-Reply-To: <55D391F6.6060406@opensource.altera.com>

On Tuesday, August 18, 2015 at 10:13:42 PM, Dinh Nguyen wrote:
> On 8/10/15 5:59 PM, Marek Vasut wrote:
> > This gem is really really rare, there was an actual float used in
> > the Altera DDR init code, which pulled in floating point ops from
> > the libgcc, just wow.
> > 
> > Since we don't support floating point operations the same way Linux
> > does not support them, replace this with an integer multiplication
> > and division combo. This removes some 2kiB of size from the SPL as
> > the floating point ops are no longer pulled in from libgcc.
> > 
> > This was detected by enabling CONFIG_USE_PRIVATE_LIBGCC=y , which
> > does not contain the floating point bits.

Private libgcc is indeed helpful! :-)

> > Signed-off-by: Marek Vasut <marex@denx.de>
> > ---
> > 
> >  drivers/ddr/altera/sequencer.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/ddr/altera/sequencer.c
> > b/drivers/ddr/altera/sequencer.c index 2bd0109..f3621cf 100644
> 
> Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com>

Applied to u-boot-socfpga/master, thanks!

Best regards,
Marek Vasut

      reply	other threads:[~2015-08-18 22:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 22:59 [U-Boot] [PATCH 1/2] ddr: altera: Replace float multiplication with integer one Marek Vasut
2015-08-10 22:59 ` [U-Boot] [PATCH 2/2] ddr: altera: Repair uninited variable Marek Vasut
2015-08-18 20:14   ` Dinh Nguyen
2015-08-18 22:06     ` Marek Vasut
2015-08-18 20:13 ` [U-Boot] [PATCH 1/2] ddr: altera: Replace float multiplication with integer one Dinh Nguyen
2015-08-18 22:07   ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201508190007.26717.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox