From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] arm: socfpga: config: Remove hard-coded drvsel and smpsel
Date: Wed, 19 Aug 2015 09:37:27 +0200 [thread overview]
Message-ID: <201508190937.28082.marex@denx.de> (raw)
In-Reply-To: <1439963714-2561-1-git-send-email-clsee@altera.com>
On Wednesday, August 19, 2015 at 07:55:14 AM, Chin Liang See wrote:
> Remove hard-coded SDMMC timing parameter drvsel and smplsel.
> This setting now will come from SDMMC calibration
>
> Signed-off-by: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> include/configs/socfpga_common.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/include/configs/socfpga_common.h
> b/include/configs/socfpga_common.h index 5ca45a9..1ca795c 100644
> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -155,8 +155,6 @@
> #define CONFIG_DWMMC
> #define CONFIG_SOCFPGA_DWMMC
> #define CONFIG_SOCFPGA_DWMMC_FIFO_DEPTH 1024
I believe this is pulled from DT nowaways, so feel free to send a separate
patch to remove this from here and README.socfpga.
> -#define CONFIG_SOCFPGA_DWMMC_DRVSEL 3
> -#define CONFIG_SOCFPGA_DWMMC_SMPSEL 0
Certainly, I agree, this horribleness should go away.
> /* FIXME */
> /* using smaller max blk cnt to avoid flooding the limited stack we have
> */ #define CONFIG_SYS_MMC_MAX_BLK_COUNT 256 /* FIXME -- SPL only? */
Now that you're digging in the SD/MMC stuff -- is this still relevant at all?
I don't think so, so you should be able to remove this as well (again, in a
separate patch and with a sufficient amount of testing).
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-08-19 7:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 5:55 [U-Boot] [PATCH 2/2] arm: socfpga: config: Remove hard-coded drvsel and smpsel Chin Liang See
2015-08-19 7:37 ` Marek Vasut [this message]
2015-08-19 8:22 ` Chin Liang See
2015-08-19 19:17 ` Marek Vasut
2015-08-20 5:15 ` Chin Liang See
2015-08-20 5:27 ` Marek Vasut
2015-08-20 6:58 ` Chin Liang See
2015-08-20 7:23 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201508190937.28082.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox