From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 19 Aug 2015 21:17:54 +0200 Subject: [U-Boot] [PATCH 2/2] arm: socfpga: config: Remove hard-coded drvsel and smpsel In-Reply-To: <1439972541.3518.2.camel@clsee-VirtualBox.altera.com> References: <1439963714-2561-1-git-send-email-clsee@altera.com> <201508190937.28082.marex@denx.de> <1439972541.3518.2.camel@clsee-VirtualBox.altera.com> Message-ID: <201508192117.54377.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, August 19, 2015 at 10:22:21 AM, Chin Liang See wrote: > Hi, Hi, > On Wed, 2015-08-19 at 09:37 +0200, marex at denx.de wrote: > > On Wednesday, August 19, 2015 at 07:55:14 AM, Chin Liang See wrote: > > > Remove hard-coded SDMMC timing parameter drvsel and smplsel. > > > This setting now will come from SDMMC calibration > > > > > > Signed-off-by: Chin Liang See > > > Cc: Dinh Nguyen > > > Cc: Pavel Machek > > > Cc: Marek Vasut > > > Cc: Wolfgang Denk > > > Cc: Stefan Roese > > > Cc: Tom Rini > > > --- > > > > > > include/configs/socfpga_common.h | 2 -- > > > 1 files changed, 0 insertions(+), 2 deletions(-) > > > > > > diff --git a/include/configs/socfpga_common.h > > > b/include/configs/socfpga_common.h index 5ca45a9..1ca795c 100644 > > > --- a/include/configs/socfpga_common.h > > > +++ b/include/configs/socfpga_common.h > > > @@ -155,8 +155,6 @@ > > > > > > #define CONFIG_DWMMC > > > #define CONFIG_SOCFPGA_DWMMC > > > #define CONFIG_SOCFPGA_DWMMC_FIFO_DEPTH 1024 > > > > I believe this is pulled from DT nowaways, so feel free to send a > > separate patch to remove this from here and README.socfpga. > > > > > -#define CONFIG_SOCFPGA_DWMMC_DRVSEL 3 > > > -#define CONFIG_SOCFPGA_DWMMC_SMPSEL 0 > > > > Certainly, I agree, this horribleness should go away. > > > > > /* FIXME */ > > > /* using smaller max blk cnt to avoid flooding the limited stack we > > > have > > > > > > */ #define CONFIG_SYS_MMC_MAX_BLK_COUNT 256 /* FIXME -- SPL only? */ > > > > Now that you're digging in the SD/MMC stuff -- is this still relevant at > > all? I don't think so, so you should be able to remove this as well > > (again, in a separate patch and with a sufficient amount of testing). > > Ok, let me take a look into this. > Thanks Cool, thanks! Best regards, Marek Vasut