From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 21 Aug 2015 05:03:29 +0200 Subject: [U-Boot] [PATCH v2 1/2] arm: socfpga: mmc: Enable calibration for drvsel and smpsel In-Reply-To: <1440120300.1969.4.camel@clsee-VirtualBox> References: <1440055109-2252-1-git-send-email-clsee@altera.com> <201508210307.38728.marex@denx.de> <1440120300.1969.4.camel@clsee-VirtualBox> Message-ID: <201508210503.29758.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, August 21, 2015 at 03:25:00 AM, Chin Liang See wrote: > On Fri, 2015-08-21 at 03:07 +0200, marex at denx.de wrote: > > On Friday, August 21, 2015 at 02:54:00 AM, Chin Liang See wrote: > > > Hi guys, > > > > Hi, Hi, > > > Any comment or ack for this patch? > > > > Please don't expect that the reviewers/maintainers have nothing else on > > their plate but to review your patch. Besides, this change is really low > > priority one, since thus far the SD/MMC works fine on all of the SoCFPGA > > boards to my knowledge. > > > > Also, I thought we agreed to wait for Simon to comment on this patch. > > You don't have to repost a patch before the discussion settles a bit. > > This doesn't help, it only puts burden on the receiving side, chill :) > > Let alone the fact that this code should be part of the DWMMC core, as > > it is not socfpga specific. > > > > What I would be really interested in is a proper description of the > > calibration algorithm. What is the goal and how do you achieve it ? > > Actually I am probing the efforts needed for this patch before moving to > next one. While for the SDMMC calibration, it is not needed if the SD > card is routed near to the chip. We have incident where SD access failed > as they routed few inches away. Does the calibration really help or is that a problem with the board ? It'd be nice if you put effort into this patch to get it done correctly :) > With that, let wait for Simon and I shall move on next item. If you're waiting for Simon, it might be a good idea to actually CC him :-) Best regards, Marek Vasut