public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] h2200: Fix build error
Date: Fri, 21 Aug 2015 07:33:23 +0200	[thread overview]
Message-ID: <201508210733.23185.marex@denx.de> (raw)
In-Reply-To: <1440135124-9379-1-git-send-email-kishon@ti.com>

On Friday, August 21, 2015 at 07:32:04 AM, Kishon Vijay Abraham I wrote:
> Commit <8bfc288c3955> ("usb: gadget: ether: Perform board
> initialization from ethernet gadget driver") added board_usb_init
> and board_usb_cleanup in ethernet gadget driver. But h2200 board
> didn't have board_usb_init and board_usb_cleanup implementations.
> 
> This introduced the following build errors
> +drivers/usb/gadget/built-in.o: In function `usb_eth_halt':
> +drivers/usb/gadget/ether.c:2498: undefined reference to
> `board_usb_cleanup' +drivers/usb/gadget/built-in.o: In function
> `usb_eth_init':
> +drivers/usb/gadget/ether.c:2316: undefined reference to `board_usb_init'
> 
> Fix it here by adding empty board_usb_init and board_usb_cleanup
> functions in h2200.c.
> 
> Fixes: <8bfc288c3955> ("usb: gadget: ether: Perform board
> initialization from ethernet gadget driver")
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  board/h2200/h2200.c |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/board/h2200/h2200.c b/board/h2200/h2200.c
> index 66ae4b6..01f8e67 100644
> --- a/board/h2200/h2200.c
> +++ b/board/h2200/h2200.c
> @@ -59,3 +59,15 @@ int dram_init(void)
>  	gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
>  	return 0;
>  }
> +
> +#ifdef CONFIG_USB_GADGET_PXA2XX
> +int board_usb_init(int index, enum usb_init_type init)
> +{
> +	return 0;
> +}
> +
> +int board_usb_cleanup(int index, enum usb_init_type init)
> +{
> +	return 0;
> +}
> +#endif

Shouldn't this go into the PXA2xx UDC driver instead as a set of
__weak functions ?

Best regards,
Marek Vasut

  reply	other threads:[~2015-08-21  5:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21  5:32 [U-Boot] [PATCH] h2200: Fix build error Kishon Vijay Abraham I
2015-08-21  5:33 ` Marek Vasut [this message]
2015-08-21  5:43   ` Kishon Vijay Abraham I
2015-08-21  5:45     ` Marek Vasut
2015-08-21  5:47       ` Kishon Vijay Abraham I
2015-08-24 18:42 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201508210733.23185.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox