From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Ruder <andy@aeruder.net>
Date: Fri, 21 Aug 2015 06:25:58 -0500
Subject: [U-Boot] [PATCH V2 3/5] dm9000: Add struct eth_device * to SROM
 functions
In-Reply-To: <CANr=Z=bvk3Puzc9hLxOwq6eV8oon_iMoa6_hq0vzm=CTNMK9DQ@mail.gmail.com>
References: <1439400246-20472-1-git-send-email-andrew.ruder@elecsyscorp.com>
 <1439400246-20472-4-git-send-email-andrew.ruder@elecsyscorp.com>
 <CANr=Z=bvk3Puzc9hLxOwq6eV8oon_iMoa6_hq0vzm=CTNMK9DQ@mail.gmail.com>
Message-ID: <20150821112558.GA21772@og3k.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wed, Aug 12, 2015 at 02:07:20PM -0500, Joe Hershberger wrote:
> On Wed, Aug 12, 2015 at 12:24 PM, Andrew Ruder
> <andrew.ruder@elecsyscorp.com> wrote:
> >  /******************  function prototypes **********************/
> >  #if !defined(CONFIG_DM9000_NO_SROM)
> > -void dm9000_write_srom_word(int offset, u16 val);
> > -void dm9000_read_srom_word(int offset, u8 *to);
> > +struct eth_device;
> > +
> > +void dm9000_write_srom_word(struct eth_device *dev, int offset, u16 val);
> > +void dm9000_read_srom_word(struct eth_device *dev, int offset, u8 *to);
> 
> It will be better to pass the dm9000_priv* instead. See patch 5 for details.

Even on the "public"-facing functions?

Thanks,
Andrew