public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andrew Ruder <andy@aeruder.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c: adding driver for pxa27x, pxa3xx, pxa25x
Date: Fri, 21 Aug 2015 07:04:37 -0500	[thread overview]
Message-ID: <20150821120437.GB21772@og3k.com> (raw)
In-Reply-To: <201508122134.14593.marex@denx.de>

On Wed, Aug 12, 2015 at 09:34:14PM +0200, Marek Vasut wrote:
> On Wednesday, August 12, 2015 at 08:43:52 PM, Andrew Ruder wrote:
> > +#if !defined(CONFIG_SYS_PXA_STD_I2C_SPEED)
> > +#define CONFIG_SYS_PXA_STD_I2C_SPEED 100000
> > +#endif
> > +
> > +#if !defined(CONFIG_SYS_PXA_STD_I2C_SLAVE)
> > +#define CONFIG_SYS_PXA_STD_I2C_SLAVE 1
> > +#endif
> > +
> > +#if !defined(CONFIG_SYS_PXA_PWR_I2C_SPEED)
> > +#define CONFIG_SYS_PXA_PWR_I2C_SPEED 40000
> > +#endif
> > +
> > +#if !defined(CONFIG_SYS_PXA_PWR_I2C_SLAVE)
> > +#define CONFIG_SYS_PXA_PWR_I2C_SLAVE 1
> > +#endif
> 
> Please remove all this stuff, it's only going to hide bugs.

Hide in what way?  Just require that ports define them when enabling the
i2c driver?  ... or don't make it externally configurable?

Thanks,
Andrew

  parent reply	other threads:[~2015-08-21 12:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12 18:43 [U-Boot] [PATCH] i2c: adding driver for pxa27x, pxa3xx, pxa25x Andrew Ruder
2015-08-12 19:34 ` Marek Vasut
2015-08-12 20:19   ` Andrew Ruder
2015-08-12 20:34     ` Marek Vasut
2015-08-21 12:04   ` Andrew Ruder [this message]
2015-08-16  0:34 ` Marcel Ziswiler
2015-08-16  0:57   ` Marek Vasut
2015-08-16  1:13     ` Marcel Ziswiler
2015-08-16  2:12       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150821120437.GB21772@og3k.com \
    --to=andy@aeruder.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox