public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dm: core: Add Kconfig for simple bus driver
Date: Sun, 23 Aug 2015 03:12:24 +0200	[thread overview]
Message-ID: <201508230312.24600.marex@denx.de> (raw)
In-Reply-To: <CAPnjgZ3VVC-51J7uDbFgQ+C7dt9fwaFXEdUJ+pFKtQBC+YLthg@mail.gmail.com>

On Saturday, August 22, 2015 at 07:09:21 PM, Simon Glass wrote:
> Hi Marek,

Hi Simon,

> On 22 August 2015 at 10:48, Marek Vasut <marex@denx.de> wrote:
> > On Saturday, August 22, 2015 at 06:01:44 PM, Simon Glass wrote:
> >> Hi Marek,
> > 
> > Hi!
> > 
> >> On 22 August 2015 at 09:50, Marek Vasut <marex@denx.de> wrote:
> >> > On Saturday, August 22, 2015 at 03:40:26 PM, Simon Glass wrote:
> >> > 
> >> > Hi!
> >> > 
> >> > [...]
> >> > 
> >> >> >> One way or another we'll figure this out sooner rather than later.
> >> >> > 
> >> >> > I know :)
> >> >> 
> >> >> Masahiro's series landed so I have applied this to u-boot-dm.
> >> >> 
> >> >> Please check that it works as you expect.
> >> > 
> >> > I think we're having a minor duplicity here now. Check the
> >> > 
> >> > drivers/core/Makefile, there's this bit already:
> >> >  obj-$(CONFIG_$(SPL_)OF_CONTROL) += simple-bus.o
> >> > 
> >> > And since I have both CONFIG_OF_CONTROL and CONFIG_SPL_OF_CONTROL, I
> >> > get the simple bus driver as well.
> >> > 
> >> > But I don't think that the current state is entirely correct. I
> >> > propose the remove the above obj-$(CONFIG_$(SPL_)OF_CONTROL) +=
> >> > simple-bus.o from the Makefile to fix the duplicity and achieve the
> >> > behavior you wanted to have. What do you think please ? I can send a
> >> > quick patch.
> >> 
> >> Actually I think that is just a merge error that I made. Can you
> >> please check it now?
> > 
> > I think the in drivers/core/Kconfig , the SPL_SIMPLE_BUS should now
> > depend on SPL_OF_CONTROL, not on OF_CONTROL, right ? :)
> 
> Ah yes that sounds right. Would you like to send a new patch against
> mainline? I think it is best to consider this a rewrite rather than a
> merge!

Heh :) I think that's the last missing bit, so feel free to fix it and
we're good. But if you insist on a new patch, please do let me know :)

Best regards,
Marek Vasut

  reply	other threads:[~2015-08-23  1:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-02 23:15 [U-Boot] [PATCH] dm: core: Add Kconfig for simple bus driver Marek Vasut
2015-08-02 23:52 ` Simon Glass
2015-08-02 23:55   ` Marek Vasut
2015-08-02 23:58     ` Simon Glass
2015-08-10 13:39   ` Simon Glass
2015-08-10 13:57     ` Marek Vasut
2015-08-10 14:00       ` Simon Glass
2015-08-10 14:03         ` Marek Vasut
2015-08-22 13:40           ` Simon Glass
2015-08-22 15:50             ` Marek Vasut
2015-08-22 16:01               ` Simon Glass
2015-08-22 16:48                 ` Marek Vasut
2015-08-22 17:09                   ` Simon Glass
2015-08-23  1:12                     ` Marek Vasut [this message]
2015-08-23 21:21                       ` Simon Glass
2015-08-24  2:54                         ` Marek Vasut
2015-08-24 10:02                           ` Masahiro Yamada
2015-08-24 10:14                             ` Marek Vasut
2015-08-24 16:58                             ` Simon Glass
2015-08-30 22:42                               ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201508230312.24600.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox