From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 24 Aug 2015 12:11:41 -0400 Subject: [U-Boot] [PATCH 3/3] include: configs: Enable DWC3 and DFU in ti_omap5_common In-Reply-To: <55D6BDCD.7050701@ti.com> References: <1439973801-12616-1-git-send-email-kishon@ti.com> <1439973801-12616-4-git-send-email-kishon@ti.com> <20150820175621.GW25532@bill-the-cat> <55D6BDCD.7050701@ti.com> Message-ID: <20150824161141.GF25532@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Aug 21, 2015 at 11:27:33AM +0530, Kishon Vijay Abraham I wrote: > Hi Tom, > > On Thursday 20 August 2015 11:26 PM, Tom Rini wrote: > > On Wed, Aug 19, 2015 at 02:13:21PM +0530, Kishon Vijay Abraham I wrote: > > > >> Enabled configs for dwc3, dwc3-omap and PHY for dwc3 in > >> ti_omap5_common. Also enabled support for DFU. > >> > >> Since ti_omap5_common is used by dra7 too, removed these configs > >> from dra7xx_evm config file. > >> > >> Signed-off-by: Kishon Vijay Abraham I > > > > This is starting to move board-specific stuff (like using DFU) into the > > common file for all OMAP5 boards, so I don't like this. NAK in concept, > > thanks! > > Since we have added support for DFU for all the OMAP5 based boards > (including DRA's), thought it is better to add in a common file which is > used by all these boards. > > So do you prefer the configs be added in dra7xx_evm.h, omap5_evm.h, > beagle_x15.h etc.. Yes in each config. As we can see from when am335x (and am43xx now) starts getting used outside of TI some assumptions get changed and we still want them opting in on the comon header files :) -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: