public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 5/7] video: cfb_console: Allow VGA device to work without i8042 keyboard
Date: Tue, 25 Aug 2015 09:54:28 +0200	[thread overview]
Message-ID: <20150825095428.3031c3a6@crub> (raw)
In-Reply-To: <CAPnjgZ2vQQ7GByakuPXCz4Tv7oY9nUKr0zOGio0+vb3uR+d9Sw@mail.gmail.com>

Hi Simon,

On Mon, 24 Aug 2015 22:13:41 -0600
Simon Glass <sjg@chromium.org> wrote:

> On 24 August 2015 at 02:00, Bin Meng <bmeng.cn@gmail.com> wrote:
> > So far if CONFIG_VGA_AS_SINGLE_DEVICE is not defined, the VGA device
> > will try to initialize a keyboard device (for x86, it is i8042). But
> > if i8042 controller initialization fails (eg: there is no keyboard
> > connected to the PS/2 port), drv_video_init() just simply returns.
> > This kills the opportunity of using a usb keyboard later with the vga
> > console, as the vga initialization part is actually ok, only keyboard
> > part fails. Change the code logic to allow this.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> What are your thoughts on this patch, please?

it is okay for me, please merge it with other patches in this series.

Thanks,

Anatolij

  reply	other threads:[~2015-08-25  7:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24  8:00 [U-Boot] [PATCH v3 1/7] x86: i8042: Remove unused codes Bin Meng
2015-08-24  8:00 ` [U-Boot] [PATCH v3 2/7] x86: i8042: Reorder static functions Bin Meng
2015-08-26 14:56   ` Simon Glass
2015-08-24  8:00 ` [U-Boot] [PATCH v3 3/7] x86: i8042: Clean up the driver per coding convention Bin Meng
2015-08-26 14:56   ` Simon Glass
2015-08-24  8:00 ` [U-Boot] [PATCH v3 4/7] x86: i8042: Correctly initialize the controller Bin Meng
2015-08-26 14:56   ` Simon Glass
2015-08-24  8:00 ` [U-Boot] [PATCH v3 5/7] video: cfb_console: Allow VGA device to work without i8042 keyboard Bin Meng
2015-08-25  4:13   ` Simon Glass
2015-08-25  7:54     ` Anatolij Gustschin [this message]
2015-08-26 14:56       ` Simon Glass
2015-08-25  7:45   ` Anatolij Gustschin
2015-08-24  8:00 ` [U-Boot] [PATCH v3 6/7] x86: crownbay: Enable on-board SMSC superio keyboard controller Bin Meng
2015-08-26 14:56   ` Simon Glass
2015-08-24  8:00 ` [U-Boot] [PATCH v3 7/7] video: ct69000: Remove unused codes Bin Meng
2015-08-25  5:04   ` Simon Glass
2015-08-25  7:49   ` Anatolij Gustschin
2015-08-26 14:56     ` Simon Glass
2015-08-25  4:13 ` [U-Boot] [PATCH v3 1/7] x86: i8042: " Simon Glass
2015-08-26 14:56   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150825095428.3031c3a6@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox