From: Pavel Machek <pavel@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Change default tftp timeout to be rfc-compliant
Date: Tue, 25 Aug 2015 16:32:48 +0200 [thread overview]
Message-ID: <20150825143248.GA4785@amd> (raw)
In-Reply-To: <CAEUhbmXQb1h+Ho1Z_NstU0L6mdnH3VN3D=PfoY7Y7GaKtspe-A@mail.gmail.com>
On Tue 2015-08-25 21:03:26, Bin Meng wrote:
> Hi Pavel, Joe,
>
> On Tue, Aug 25, 2015 at 7:44 PM, Pavel Machek <pavel@denx.de> wrote:
> >
> >
> > tftp timeout of 100msec gives good performance on local ethernet, but
> > some servers (Centos) refuse to operate, and it is against RFC 2349.
> >
> > This fixes regression caused by
> > 620776d734e4b126c407f636bda825a594a17723 .
> >
>
> This patch does not fix the issue properly. As the commit 620776d also
> changed the "<1000" test logic to "<10", which should not be. See my
> comments below.
Yes, I know.. and I'd like the test logic to stay. Some tftp servers
can handle that, and performance is significantly better that way.
Best regards,
Pavel
> I still would like to revert commit 620776d (IOW, apply my revert
> patch @ http://patchwork.ozlabs.org/patch/510389/). Then Pavel to
> submit a new patch to change only TIMEOUT_COUNT to something larger (I
> am still not convinced that we need change the retry count from 10 to
> 1000). Perhaps with a better comment in the codes to explain why a
> larger TIMEOUT_COUNT is needed.
>
> Regards,
> Bin
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-08-25 14:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 2:25 [U-Boot] commit 620776d causes TFTP error: 'Unsupported option(s) requested' (8) Bin Meng
2015-08-25 3:42 ` Joe Hershberger
2015-08-25 4:05 ` Bin Meng
2015-08-25 4:24 ` Joe Hershberger
2015-08-25 7:40 ` Bin Meng
2015-08-25 12:13 ` Hannes Schmelzer
2015-08-25 12:19 ` Pavel Machek
2015-08-25 12:23 ` Hannes Schmelzer
2015-09-10 22:26 ` Alexey Brodkin
2015-09-10 22:46 ` Joe Hershberger
2015-09-10 22:51 ` Simon Glass
2015-08-25 7:12 ` Pavel Machek
2015-08-25 8:58 ` Bin Meng
2015-08-25 9:22 ` Bin Meng
2015-08-25 11:28 ` Pavel Machek
2015-08-25 11:44 ` [U-Boot] [PATCH] Change default tftp timeout to be rfc-compliant Pavel Machek
2015-08-25 13:03 ` Bin Meng
2015-08-25 14:32 ` Pavel Machek [this message]
2015-08-25 14:49 ` Tom Rini
2015-08-25 15:33 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825143248.GA4785@amd \
--to=pavel@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox