From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spi: cadence_qspi: Enable quad mode for read and programming
Date: Wed, 26 Aug 2015 15:58:44 +0200 [thread overview]
Message-ID: <201508261558.44818.marex@denx.de> (raw)
In-Reply-To: <1440596556.1934.25.camel@clsee-VirtualBox>
On Wednesday, August 26, 2015 at 03:42:36 PM, Chin Liang See wrote:
> On Wed, 2015-08-26 at 15:37 +0200, marex at denx.de wrote:
> > On Wednesday, August 26, 2015 at 03:13:15 PM, Chin Liang See wrote:
> >
> > Hi,
> >
> > [...]
> >
> > > > > Yah, that is a nice enhancement in order to keep up with controller
> > > > > enhancement. We definitely want to explore and enable that at
> > > > > U-Boot in the future.
> > > >
> > > > You mean you'll implement this functionality and then make your
> > > > change to the QSPI driver to use it, in order to implement things
> > > > properly ? :) In that case, I agree.
> > >
> > > Sure, something I can look at in 1-2 months time.
> >
> > Sure, no problem, that should be in time for the next merge window.
> >
> > > I still have laundry
> > > lists on ensuring the mainline SOCFPGA U-Boot has all the essential
> > > features as we have in github. Prior that happen, can I get an ACK from
> > > you? :)
> >
> > No, sorry, you can not get ack on a patch which is hacky. You cannot push
> > hacky code into mainline just for the sake of getting something somehow
> > working, that's not how it works. We either do things proper or not at
> > all.
>
> In this case, probably its something we can work together on enabling
> the spi-nor?
Hi!
But the Cadence QSPI works in U-Boot, I'm using it on a board here.
If you need additional features, I'm glad to ack patches which are
done right.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-08-26 13:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 0:09 [U-Boot] [PATCH] spi: cadence_qspi: Enable quad mode for read and programming Chin Liang See
2015-08-26 6:57 ` Marek Vasut
2015-08-26 7:30 ` Chin Liang See
2015-08-26 7:57 ` Marek Vasut
2015-08-26 8:42 ` Chin Liang See
2015-08-26 9:07 ` Marek Vasut
2015-08-26 13:13 ` Chin Liang See
2015-08-26 13:37 ` Marek Vasut
2015-08-26 13:42 ` Chin Liang See
2015-08-26 13:58 ` Marek Vasut [this message]
2015-08-27 5:14 ` Chin Liang See
2015-08-27 8:30 ` Marek Vasut
2015-08-26 13:47 ` Jagan Teki
2015-08-26 13:58 ` Chin Liang See
2015-08-26 13:59 ` Marek Vasut
2015-08-26 14:39 ` Jagan Teki
2015-08-26 14:44 ` Marek Vasut
2015-08-26 14:52 ` Jagan Teki
2015-08-26 15:57 ` Tom Rini
2015-08-26 16:55 ` Jagan Teki
2015-08-26 13:19 ` Simon Glass
2015-08-26 13:38 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201508261558.44818.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox