public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] image: fix Android ramdisk support when dtb is specified
Date: Thu, 27 Aug 2015 15:43:49 -0400	[thread overview]
Message-ID: <20150827194349.GD25532@bill-the-cat> (raw)
In-Reply-To: <1440699756.2601.21.camel@collins>

On Thu, Aug 27, 2015 at 08:22:36PM +0200, Paul Kocialkowski wrote:
> Le vendredi 17 juillet 2015 ? 10:57 -0500, Rob Herring a ?crit :
> > If a dtb is specified on the command-line, the Android boot image ramdisk
> > will not be found. Fix this so that we can specify the ramdisk address and
> > dtb address. The syntax is to enter the Android boot image address for
> > both the kernel and ramdisk.
> 
> This commit breaks booting non-fdt Android images (the kernel doesn't
> find the initramfs, and neither does U-Boot).
> 
> The test to enter the code block where Android ramdisk support was moved
> is accessed with:
> else if (select || genimg_has_config(images)) {
> 
> However, in a non-fdt context, select is NULL and genimg_has_config
> returns 0.
> 
> I suggest we either duplicate Android ramdisk support in the non-fdt
> path or adapt the condition to enter the code block where it was moved.

I've taken a third path, make the code check for Android images and then
"know" what the address we want to check should be.  Let me know if that
patch fixes your problem, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150827/aacd6b16/attachment.sig>

      reply	other threads:[~2015-08-27 19:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17 15:57 [U-Boot] [PATCH] image: fix Android ramdisk support when dtb is specified Rob Herring
2015-08-13 13:18 ` [U-Boot] " Tom Rini
2015-08-27 18:22 ` [U-Boot] [PATCH] " Paul Kocialkowski
2015-08-27 19:43   ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150827194349.GD25532@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox