From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 28 Aug 2015 11:24:12 +0200 Subject: [U-Boot] [PATCH] arm: socfpga: dm: Fix DM initialization failure after warm reset In-Reply-To: <55E01ECE.6020309@boschrexroth.de> References: <55E01ECE.6020309@boschrexroth.de> Message-ID: <201508281124.12560.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, August 28, 2015 at 10:41:50 AM, Jian Luo wrote: > gd->dm_root is not cleared in SPL after warm reset. > This might cause DM initilazation failure. > > Signed-off-by: Jian Luo Hi! > --- > arch/arm/mach-socfpga/spl.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/mach-socfpga/spl.c b/arch/arm/mach-socfpga/spl.c > index 13ec24b..59fe1f2 100644 > --- a/arch/arm/mach-socfpga/spl.c > +++ b/arch/arm/mach-socfpga/spl.c > @@ -181,5 +181,11 @@ void board_init_f(ulong dummy) > /* Configure simple malloc base pointer into RAM. */ > gd->malloc_base = CONFIG_SYS_TEXT_BASE + (1024 * 1024); > > + /* > + * gd->dm_root might contain non-zero value after warm reset. > + * Clear it to avoid dm_init error > + */ > + gd->dm_root = NULL; Nit: The indent should be done with tabs, not spaces. I think the email got messed up somewhere along the way. The bigger concern I have is that if you look into arch/arm/lib/crt0.S , you will see that the entire global data are cleared there (_main, label clr_gd: ) and this code is executed before the board_init_f() . Can you try tracking it down a bit more? I suspect that you might see dm_init_and_scan() returned error -22 , is that what you observe please? > board_init_r(NULL, 0); > } Best regards, Marek Vasut