public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] env_mmc: Properly prefix mmc errors with '!'
Date: Fri, 28 Aug 2015 17:02:48 -0400	[thread overview]
Message-ID: <20150828210248.GS25532@bill-the-cat> (raw)
In-Reply-To: <1439661901-9848-2-git-send-email-hdegoede@redhat.com>

On Sat, Aug 15, 2015 at 08:05:01PM +0200, Hans de Goede wrote:

> The set_default_env() function from env_common.c expects either
> a fully formatted error msg, e.g.: "## Resetting to default environment\n"
> or an error msg prefixed with an !, in which case it will format it.
> 
> Fix the init_mmc_for_env() error messages to be prefixed with a !
> this changes the bootup-log on sunxi when no mmc card is found from:
> 
> MMC:   SUNXI SD/MMC: 0
> No MMC card foundIn:    serial
> Out:   serial
> 
> To:
> 
> MMC:   SUNXI SD/MMC: 0
> *** Warning - No MMC card found, using default environment
> 
> In:    serial
> Out:   serial
> 
> Which clearly is how things should look.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150828/5da1e52e/attachment.sig>

      reply	other threads:[~2015-08-28 21:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-15 18:05 [U-Boot] [PATCH 0/1] env_mmc: Properly prefix mmc errors with '!' Hans de Goede
2015-08-15 18:05 ` [U-Boot] [PATCH] " Hans de Goede
2015-08-28 21:02   ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150828210248.GS25532@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox