From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] usb: gadget: ci_udc: implement usb_ep_ops dequeue callback
Date: Sat, 29 Aug 2015 15:57:20 +0200 [thread overview]
Message-ID: <201508291557.20703.marex@denx.de> (raw)
In-Reply-To: <1440724830-17915-1-git-send-email-Peng.Fan@freescale.com>
On Friday, August 28, 2015 at 03:20:30 AM, Peng Fan wrote:
> Implement endpoint dequeue callback function.
>
> Without this function, uboot will hang when executing fastboot comamnd.
> See following flow:
> "fastboot_tx_write_str->fastboot_tx_write->usb_ep_dequeue->ep->ops->dequeue
> " without implement ci_udc dequeue function, ep->ops->dequeue is NULL, then
> uboot will hang.
>
> Tested on mx6qsabresd board with fastboot enabled.
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Cc: "?ukasz Majewski" <l.majewski@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
>
> Changes v2:
> discard useless "debug("callback completed\n")" info.
Hi,
I see Stephen had some concerns about V1, but I don't see them addressed.
I would prefer if you sent V2 only after the discussion about the previous
version of the patch reaches a conclusion. Can you please address the
concerns Stephen had there ? Thanks!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-08-29 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 1:20 [U-Boot] [PATCH V2] usb: gadget: ci_udc: implement usb_ep_ops dequeue callback Peng Fan
2015-08-29 13:57 ` Marek Vasut [this message]
2015-09-09 23:04 ` Fabio Estevam
2015-09-09 23:20 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201508291557.20703.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox