From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sat, 29 Aug 2015 15:57:20 +0200 Subject: [U-Boot] [PATCH V2] usb: gadget: ci_udc: implement usb_ep_ops dequeue callback In-Reply-To: <1440724830-17915-1-git-send-email-Peng.Fan@freescale.com> References: <1440724830-17915-1-git-send-email-Peng.Fan@freescale.com> Message-ID: <201508291557.20703.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, August 28, 2015 at 03:20:30 AM, Peng Fan wrote: > Implement endpoint dequeue callback function. > > Without this function, uboot will hang when executing fastboot comamnd. > See following flow: > "fastboot_tx_write_str->fastboot_tx_write->usb_ep_dequeue->ep->ops->dequeue > " without implement ci_udc dequeue function, ep->ops->dequeue is NULL, then > uboot will hang. > > Tested on mx6qsabresd board with fastboot enabled. > > Signed-off-by: Peng Fan > Cc: "?ukasz Majewski" > Cc: Marek Vasut > --- > > Changes v2: > discard useless "debug("callback completed\n")" info. Hi, I see Stephen had some concerns about V1, but I don't see them addressed. I would prefer if you sent V2 only after the discussion about the previous version of the patch reaches a conclusion. Can you please address the concerns Stephen had there ? Thanks! Best regards, Marek Vasut