[U-Boot] [PATCH] arm: socfpga: Add support for the Terasic DE-0 Atlas board

Pavel Machek
2015-09-01T07:38:23Z

On Tue 2015-09-01 00:23:49, Marek Vasut wrote:
> On Monday, August 31, 2015 at 09:57:05 PM, dinguyen at opensource.altera.com wrote:
> > From: Dinh Nguyen <dinguyen@opensource.altera.com>
> >
> > Add support for the Terasic DE0-Nano/Atlas-SoC Kit, which is a CycloneV
> > based board. The board can boot from SD/MMC. Ethernet is a bit different
> > because it has a KSZ9031 PHY, so for now, ethernet doesn't quite work yet,
> > as a few patches are needed to support the PHY.
>
> I thought we did support the KSZ9031 PHY. What's the problem ?
>
> > Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> > ---
> > Hi Marek,
> >
> > This patch is based on your u-boot-socfpga/wip/boards branch.
>
> OK, that makes sense.
>
> > Thanks,
> > Dinh
> > ---
> > arch/arm/dts/Makefile | 1 +
> > arch/arm/dts/socfpga_cyclone5_de0_sockit.dts | 61 +++
> > arch/arm/mach-socfpga/Kconfig | 7 +
> > board/terasic/de0/MAINTAINERS | 5 +
> > board/terasic/de0/Makefile | 9 +
>
> I think it might be clearer to rename it to de0-nano-soc, what do you think ?
> What's the difference between de0-nano-soc and atlas btw ?

Unless they are going to make "de0-mega".. I'd say "de0" is clean
enough.

> > diff --git a/configs/socfpga_de0_defconfig b/configs/socfpga_de0_defconfig

...and matches defconfig name

> > +++ b/include/configs/socfpga_de0.h

...and header file, etc.

> > +/* Extra Environment */
> > +#define CONFIG_HOSTNAME socfpga_cyclone5
>
> socfpga_d0_nano_soc might be better ;-)

socfpga_de0 might be better. No need to have kilometer long hostnames
:-).

Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html