From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] What's purpose of DEV_FLAGS_SYSTEM and DEV_EXT_VIDEO?
Date: Wed, 2 Sep 2015 10:47:37 -0400 [thread overview]
Message-ID: <20150902144737.GV25532@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ17GUJYaUQ1TrfLW24LNfpSwLFf7O8jefZNtxwsCr75wQ@mail.gmail.com>
On Wed, Sep 02, 2015 at 08:05:47AM -0600, Simon Glass wrote:
> Hi,
>
> On 2 September 2015 at 03:44, Bin Meng <bmeng.cn@gmail.com> wrote:
> > On Mon, Aug 17, 2015 at 1:09 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> >> Hi,
> >>
> >> I plan to send a patch to remove the DEV_FLAGS_SYSTEM and
> >> DEV_EXT_VIDEO. They look useless to me. For example,
> >>
> >> $ grep -nr DEV_FLAGS_SYSTEM *
> >> arch/blackfin/cpu/jtag-console.c:186: dev.flags = DEV_FLAGS_OUTPUT |
> >> DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
> >> board/bf527-ezkit/video.c:442: videodev.flags = DEV_FLAGS_SYSTEM;
> >> /* No Output */
> >> board/kosagi/novena/novena.c:80: .flags =
> >> DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM,
> >> board/cm-bf548/video.c:336: videodev.flags = DEV_FLAGS_SYSTEM;
> >> /* No Output */
> >> board/mpl/common/kbd.c:206: kbddev.flags = DEV_FLAGS_INPUT |
> >> DEV_FLAGS_SYSTEM;
> >> board/mpl/pati/pati.c:569: pci_con_dev.flags = DEV_FLAGS_OUTPUT |
> >> DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
> >> board/bf548-ezkit/video.c:332: videodev.flags = DEV_FLAGS_SYSTEM;
> >> /* No Output */
> >> board/bf533-stamp/video.c:168: videodev.flags = DEV_FLAGS_SYSTEM;
> >> common/cmd_console.c:33: (dev->flags &
> >> DEV_FLAGS_SYSTEM) ? 'S' : '.',
> >> common/usb_kbd.c:505: usb_kbd_dev.flags = DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
> >> common/stdio.c:91: dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT
> >> | DEV_FLAGS_SYSTEM;
> >> common/stdio.c:102: dev.flags = DEV_FLAGS_OUTPUT | DEV_FLAGS_INPUT
> >> | DEV_FLAGS_SYSTEM;
> >> drivers/input/cros_ec_keyb.c:261: dev.flags = DEV_FLAGS_INPUT |
> >> DEV_FLAGS_SYSTEM;
> >> drivers/input/tegra-kbc.c:361: dev.flags = DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
> >> drivers/input/keyboard.c:277: kbddev.flags = DEV_FLAGS_INPUT |
> >> DEV_FLAGS_SYSTEM;
> >> drivers/video/cfb_console.c:2296: console_dev.flags =
> >> DEV_FLAGS_OUTPUT | DEV_FLAGS_SYSTEM;
> >> drivers/net/netconsole.c:325: dev.flags = DEV_FLAGS_OUTPUT |
> >> DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
> >> include/stdio_dev.h:19:#define DEV_FLAGS_SYSTEM 0x80000000 /*
> >> Device is a system device */
> >>
> >> Except for this one below which tests the flag and prints an 'S',
> >> common/cmd_console.c:33: (dev->flags &
> >> DEV_FLAGS_SYSTEM) ? 'S' : '.',
> >>
> >> I don't see any actual meaning of this flag. I wonder if someone on
> >> the mailing list knows the history.
> >>
> >> Also I noticed that several blackfin boards' video driver only set
> >> this flag without setting DEV_FLAGS_OUTPUT.
> >>
> >> board/bf527-ezkit/video.c:442: videodev.flags = DEV_FLAGS_SYSTEM;
> >> /* No Output */
> >> board/cm-bf548/video.c:336: videodev.flags = DEV_FLAGS_SYSTEM;
> >> /* No Output */
> >> board/bf548-ezkit/video.c:332: videodev.flags = DEV_FLAGS_SYSTEM;
> >> /* No Output */
> >> board/bf533-stamp/video.c:168: videodev.flags = DEV_FLAGS_SYSTEM;
> >>
> >> I wonder these video drivers are not used for system output purpose?
> >>
> >
> > Ping?
>
> This is from the dawn of time and I don't see any purpose still remaining.
Sounds reasonable.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150902/f4a24c03/attachment.sig>
next prev parent reply other threads:[~2015-09-02 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 5:09 [U-Boot] What's purpose of DEV_FLAGS_SYSTEM and DEV_EXT_VIDEO? Bin Meng
2015-09-02 9:44 ` Bin Meng
2015-09-02 14:05 ` Simon Glass
2015-09-02 14:47 ` Tom Rini [this message]
2015-09-02 22:25 ` Anatolij Gustschin
2015-09-06 12:20 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902144737.GV25532@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox