From: Simon Guinot <simon.guinot@sequanux.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] v2015.10-rc2: timer not initialized on Kirkwood
Date: Wed, 2 Sep 2015 17:49:30 +0200 [thread overview]
Message-ID: <20150902154930.GS30993@kw.sim.vm.gnt> (raw)
Hi,
While testing U-Boot v2015.10-rc2 on the Kirkwood-based LaCie boards
I noticed that the autoboot counter is not decrementing. It stays stuck
at '3' endlessly. After some digging, I found out that this regression
is due to the commit: ade741b3896b1a3872ff74437f04b50762d05849
"arm: mvebu: Call timer_init early before PHY and DDR init".
With this commit it appears that the timer initialization is skipped
on Kirkwood boards. As a consequence the timer is not ticking and then
all the features relying on the timer are most likely broken.
On the Kirkwood boards, the timer_init function is only called from
from the ARM init_sequence. SPL support is disabled. The problem is
that the patch introduces a static init_done variable (to prevent
multiple timer initializations). But while debugging the timer_init
function (via JTAG), I noticed that the init_done initial value is not
zero. So the function exists without initializing the timer. A possible
explanation is that timer_init is called before the U-Boot relocation,
when the BSS segment is still not available...
Maybe we should use an initialized variable instead ?
Regards,
Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150902/a0726b0b/attachment.sig>
next reply other threads:[~2015-09-02 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 15:49 Simon Guinot [this message]
2015-09-03 5:28 ` [U-Boot] v2015.10-rc2: timer not initialized on Kirkwood Stefan Roese
2015-09-03 9:05 ` Simon Guinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902154930.GS30993@kw.sim.vm.gnt \
--to=simon.guinot@sequanux.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox