public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] arm: socfpga: Do not call board_init_r() from board_init_f()
@ 2015-08-29  8:16 Marek Vasut
  2015-09-04  9:53 ` Marek Vasut
  0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2015-08-29  8:16 UTC (permalink / raw)
  To: u-boot

Instead of calling board_init_r() directly from board_init_f(), just
return from board_init_f(). This will make the code continue executing
in crt0.S _main(), from which the board_init_r() is called. This patch
aligns the SoCFPGA SPL with the correct SPL design as well as reduces
the stack utilisation slightly.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
---
 arch/arm/mach-socfpga/spl.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/mach-socfpga/spl.c b/arch/arm/mach-socfpga/spl.c
index 13ec24b..775a827 100644
--- a/arch/arm/mach-socfpga/spl.c
+++ b/arch/arm/mach-socfpga/spl.c
@@ -180,6 +180,4 @@ void board_init_f(ulong dummy)
 
 	/* Configure simple malloc base pointer into RAM. */
 	gd->malloc_base = CONFIG_SYS_TEXT_BASE + (1024 * 1024);
-
-	board_init_r(NULL, 0);
 }
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] arm: socfpga: Do not call board_init_r() from board_init_f()
  2015-08-29  8:16 [U-Boot] [PATCH] arm: socfpga: Do not call board_init_r() from board_init_f() Marek Vasut
@ 2015-09-04  9:53 ` Marek Vasut
  0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2015-09-04  9:53 UTC (permalink / raw)
  To: u-boot

On Saturday, August 29, 2015 at 10:16:20 AM, Marek Vasut wrote:
> Instead of calling board_init_r() directly from board_init_f(), just
> return from board_init_f(). This will make the code continue executing
> in crt0.S _main(), from which the board_init_r() is called. This patch
> aligns the SoCFPGA SPL with the correct SPL design as well as reduces
> the stack utilisation slightly.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>

Applied, this is needed.

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-04  9:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-29  8:16 [U-Boot] [PATCH] arm: socfpga: Do not call board_init_r() from board_init_f() Marek Vasut
2015-09-04  9:53 ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox