From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 4 Sep 2015 16:00:31 +0200 Subject: [U-Boot] [PATCH v2 5/8] nios2: remove gp assignments in link script In-Reply-To: <1441369343-4638-6-git-send-email-thomas@wytron.com.tw> References: <1441336526-23505-1-git-send-email-thomas@wytron.com.tw> <1441369343-4638-1-git-send-email-thomas@wytron.com.tw> <1441369343-4638-6-git-send-email-thomas@wytron.com.tw> Message-ID: <201509041600.31953.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, September 04, 2015 at 02:22:20 PM, Thomas Chou wrote: > Since we don't use gp for small data with option "-G0", > we use gp as global data pointer. The _gp location is > not needed. > > The ALIGN(16) was for gp only. It is removed, so that we > can get correct address of dtb in u-boot-dtb.bin image. > > Signed-off-by: Thomas Chou > --- > arch/nios2/cpu/u-boot.lds | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/nios2/cpu/u-boot.lds b/arch/nios2/cpu/u-boot.lds > index 6e174be..951785c 100644 > --- a/arch/nios2/cpu/u-boot.lds > +++ b/arch/nios2/cpu/u-boot.lds > @@ -50,9 +50,10 @@ SECTIONS > *(.gnu.linkonce.d*) > } > > - . = ALIGN(16); > - _gp = .; /* Global pointer addr */ > - PROVIDE (gp = .); > + /* gp - Since we don't use gp for small data with option "-G0", Please make the multiline comment match the kernel coding style: /* * foo * bar */ Otherwise Acked-by: Marek Vasut > + * we will use gp as global data pointer. The _gp location is > + * not needed. > + */ > > .sdata : > { Best regards, Marek Vasut