From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/4] bitops: introduce BIT() definition
Date: Mon, 7 Sep 2015 14:15:26 +0200 [thread overview]
Message-ID: <201509071415.26879.marex@denx.de> (raw)
In-Reply-To: <8a0bbcdb993ff355300abb242fa3f16d@biessmann.de>
On Monday, September 07, 2015 at 02:01:11 PM, Andreas Bie?mann wrote:
> Hi Heiko,
>
> On 2015-09-07 13:52, Heiko Schocher wrote:
> > Hello Andreas,
> >
> > Am 07.09.2015 um 13:20 schrieb Andreas Bie?mann:
> >> On 08/21/2015 07:01 PM, Heiko Schocher wrote:
> >>> introduce BIT() definition, used in at91_udc gadget
> >>> driver.
> >>>
> >>> Signed-off-by: Heiko Schocher <hs@denx.de>
> >>
> >> NAK, this one breaks a lot of boards which already defined BIT()
> >
> > Uhh... seems this BIT() macro is a big mess ...
> >
> > Hmm Wolfgang Denk NACKed a similiar patch:
> > http://lists.denx.de/pipermail/u-boot/2014-February/173669.html
> >
> > In drivers/usb/gadget/at91_udc.c BIT(x) is used only once...
> > So I fix it there and use (1 << x) there. Would be this OK?
>
> I'm fine with this solution.
On the other hand, mainline Linux is moving towards GENMASK() and BIT(),
so we should probably go with that as well.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-09-07 12:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 17:01 [U-Boot] [PATCH v4 0/4] add dfu support for at91 sam9260 based boards Heiko Schocher
2015-08-21 17:01 ` [U-Boot] [PATCH v4 1/4] bitops: introduce BIT() definition Heiko Schocher
2015-08-21 19:26 ` Michael Heimpold
2015-08-21 19:29 ` Marek Vasut
2015-09-07 11:20 ` Andreas Bießmann
2015-09-07 11:52 ` Heiko Schocher
2015-09-07 12:01 ` Andreas Bießmann
2015-09-07 12:15 ` Marek Vasut [this message]
2015-09-07 12:42 ` Jagan Teki
2015-09-07 11:43 ` [U-Boot] [PATCH v5] " Andreas Bießmann
2015-09-07 11:47 ` Stefan Roese
2015-09-08 15:54 ` Tom Warren
2015-09-08 16:17 ` Anatolij Gustschin
2015-09-08 18:01 ` ivan.khoronzhuk
2015-09-09 16:22 ` Scott Wood
2015-09-09 16:37 ` Tom Rini
2015-09-09 17:10 ` Scott Wood
2015-09-09 18:58 ` Ivan Khoronzhuk
2015-09-09 18:52 ` Ivan Khoronzhuk
2015-09-09 18:59 ` Scott Wood
2015-09-09 18:25 ` Wolfgang Denk
2015-09-09 19:04 ` Scott Wood
2015-09-12 12:52 ` [U-Boot] [U-Boot,v5] " Tom Rini
2015-09-08 18:03 ` [U-Boot] [PATCH v4 1/4] " Jagan Teki
2015-08-21 17:01 ` [U-Boot] [PATCH v4 2/4] usb: gadget: at91_udc: port linux driver at91_udc Heiko Schocher
2015-08-21 17:01 ` [U-Boot] [PATCH v4 3/4] usb: gadget: at91_udc: add at91_udc into U-Boot Heiko Schocher
2015-08-21 17:01 ` [U-Boot] [PATCH v4 4/4] at91, taurus, smartweb: add dfu support Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201509071415.26879.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox