From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 8 Sep 2015 13:19:53 +0200 Subject: [U-Boot] [PATCH 2/4] spi: cadence_qspi: Fix fdt read of spi-max-frequency In-Reply-To: <1441675104-2536-1-git-send-email-clsee@altera.com> References: <1441675104-2536-1-git-send-email-clsee@altera.com> Message-ID: <201509081319.53687.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, September 08, 2015 at 03:18:24 AM, Chin Liang See wrote: > Fix the fdt read for spi-max-frequency as it's contained > in the child node. Current state of code is always > returning default value. > > Signed-off-by: Chin Liang See > Cc: Dinh Nguyen > Cc: Dinh Nguyen > Cc: Marek Vasut > Cc: Stefan Roese > Cc: Vikas Manocha > Cc: Jagannadh Teki > Cc: Pavel Machek > --- > Changes for v2 > - Add unsigned casting for plat->max_hz > --- > drivers/spi/cadence_qspi.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c > index 23c88d5..8c0f7dd 100644 > --- a/drivers/spi/cadence_qspi.c > +++ b/drivers/spi/cadence_qspi.c > @@ -296,10 +296,6 @@ static int cadence_spi_ofdata_to_platdata(struct > udevice *bus) plat->regbase = (void *)data[0]; > plat->ahbbase = (void *)data[2]; > > - /* Use 500KHz as a suitable default */ > - plat->max_hz = fdtdec_get_int(blob, node, "spi-max-frequency", > - 500000); > - > /* All other paramters are embedded in the child node */ > subnode = fdt_first_subnode(blob, node); > if (subnode < 0) { > @@ -307,6 +303,10 @@ static int cadence_spi_ofdata_to_platdata(struct > udevice *bus) return -ENODEV; > } > > + /* Use 500KHz as a suitable default */ > + plat->max_hz = (unsigned int)fdtdec_get_int(blob, subnode, > + "spi-max-frequency", 500000); > + fdt_getprop_u32() might be the right thing to do here :) Best regards, Marek Vasut