From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/10] usb: gadget: don't leak configs when unbinding
Date: Tue, 08 Sep 2015 14:00:37 +0200 [thread overview]
Message-ID: <20150908140037.0da2a061@amdc2363> (raw)
In-Reply-To: <1441425831-3441-1-git-send-email-swarren@wwwdotorg.org>
Hi Stephen,
> From: Stephen Warren <swarren@nvidia.com>
>
> By the time g_dnl_unbind() is run, cdev->config has been set to NULL,
> so the free() there does nothing, and the config struct is leaked.
> Equally, struct usb_gadget contains a linked list of config structs,
> so the code should iterate over them all and free each one, rather
> than freeing one particular config struct.
>
> composite_unbind() already iterates over the list of config structs,
> and unlinks each from the linked list. Fix this loop to free() each
> struct as it's unlinked and otherwise forgotten.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> drivers/usb/gadget/composite.c | 1 +
> drivers/usb/gadget/g_dnl.c | 2 --
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/composite.c
> b/drivers/usb/gadget/composite.c index d96296cd73b1..a13b21d0a0f2
> 100644 --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -948,6 +948,7 @@ static void composite_unbind(struct usb_gadget
> *gadget) debug("unbind config '%s'/%p\n", c->label, c);
> c->unbind(c);
> }
> + free(c);
> }
> if (composite->unbind)
> composite->unbind(cdev);
> diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c
> index ad89a0d2e670..2fa6da4091e1 100644
> --- a/drivers/usb/gadget/g_dnl.c
> +++ b/drivers/usb/gadget/g_dnl.c
> @@ -93,8 +93,6 @@ static int g_dnl_unbind(struct usb_composite_dev
> *cdev) {
> struct usb_gadget *gadget = cdev->gadget;
>
> - free(cdev->config);
> - cdev->config = NULL;
> debug("%s: calling usb_gadget_disconnect for "
> "controller '%s'\n", __func__, gadget->name);
> usb_gadget_disconnect(gadget);
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Tested-by: Lukasz Majewski <l.majewski@samsung.com>
Test HW: Odroid XU3 - Exynos5433.
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2015-09-08 12:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 4:03 [U-Boot] [PATCH 01/10] usb: gadget: don't leak configs when unbinding Stephen Warren
2015-09-05 4:03 ` [U-Boot] [PATCH 02/10] ext4: avoid calling ext4fs_mount() twice, which leaks Stephen Warren
2015-09-08 13:22 ` Lukasz Majewski
2015-09-12 12:51 ` [U-Boot] [U-Boot, " Tom Rini
2015-09-05 4:03 ` [U-Boot] [PATCH 03/10] ext4: free allocations by parse_path() Stephen Warren
2015-09-08 13:10 ` Lukasz Majewski
2015-09-12 12:51 ` [U-Boot] [U-Boot,03/10] " Tom Rini
2015-09-05 4:03 ` [U-Boot] [PATCH 04/10] ext4: fix leak in check_filename() Stephen Warren
2015-09-08 13:05 ` Lukasz Majewski
2015-09-12 12:51 ` [U-Boot] [U-Boot,04/10] " Tom Rini
2015-09-05 4:03 ` [U-Boot] [PATCH 05/10] dfu: don't keep freeing/reallocating Stephen Warren
2015-09-08 12:32 ` Lukasz Majewski
2015-09-12 12:51 ` [U-Boot] [U-Boot,05/10] " Tom Rini
2015-09-05 4:03 ` [U-Boot] [PATCH 06/10] dfu: mmc: buffer file reads too Stephen Warren
2015-09-08 12:57 ` Lukasz Majewski
2015-09-12 12:51 ` [U-Boot] [U-Boot,06/10] " Tom Rini
2015-09-05 4:03 ` [U-Boot] [PATCH 07/10] ARM: tegra: fix malloc region sizing Stephen Warren
2015-09-08 16:53 ` Tom Warren
2015-09-08 21:45 ` Stephen Warren
2015-09-08 21:52 ` Stephen Warren
2015-09-08 21:56 ` Tom Rini
2015-09-08 21:56 ` Stephen Warren
2015-09-09 6:51 ` Lukasz Majewski
2015-09-09 16:08 ` Tom Warren
2015-09-12 12:51 ` [U-Boot] [U-Boot,07/10] " Tom Rini
2015-09-05 4:03 ` [U-Boot] [PATCH 08/10] ARM: tegra: tweak DFU buffer sizes Stephen Warren
2015-09-12 12:51 ` [U-Boot] [U-Boot,08/10] " Tom Rini
2015-09-05 4:03 ` [U-Boot] [PATCH 09/10] ARM: tegra: enable filesystem writing Stephen Warren
2015-09-12 12:51 ` [U-Boot] [U-Boot,09/10] " Tom Rini
2015-09-05 4:03 ` [U-Boot] [PATCH 10/10] ARM: tegra: enable DFU for RAM Stephen Warren
2015-09-12 12:51 ` [U-Boot] [U-Boot,10/10] " Tom Rini
2015-09-08 12:00 ` Lukasz Majewski [this message]
2015-09-08 21:50 ` [U-Boot] [PATCH 01/10] usb: gadget: don't leak configs when unbinding Stephen Warren
2015-09-12 12:51 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908140037.0da2a061@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox