From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/28] dm: input: Create a keyboard uclass
Date: Wed, 9 Sep 2015 14:17:11 +0200 [thread overview]
Message-ID: <201509091417.11168.marex@denx.de> (raw)
In-Reply-To: <1441773171-4575-2-git-send-email-sjg@chromium.org>
On Wednesday, September 09, 2015 at 06:32:24 AM, Simon Glass wrote:
> Add a uclass for keyboard input, mirroring the existing stdio methods.
> This is enabled by a new CONFIG_DM_KEYBOARD option.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
[...]
> +static int keyboard_pre_probe(struct udevice *dev)
> +{
> + struct keyboard_priv *priv = dev_get_uclass_priv(dev);
> + struct stdio_dev *sdev = &priv->sdev;
> + int ret;
> +
> + strlcpy(sdev->name, dev->name, sizeof(sdev->name));
> + sdev->flags = DEV_FLAGS_INPUT | DEV_FLAGS_SYSTEM;
> + sdev->getc = keyboard_getc;
> + sdev->tstc = keyboard_tstc;
> + sdev->start = keyboard_start;
> + sdev->stop = keyboard_stop;
> + sdev->priv = dev;
> + ret = input_init(&priv->input, 0);
> + if (ret) {
> + debug("%s: Cannot set up input\n", __func__);
Some better identification of the failing input here would be nice.
> + return ret;
> + }
> +
> + return 0;
> +}
Otherwise,
Reviewed-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-09-09 12:17 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 4:32 [U-Boot] [PATCH 00/28] dm: input: Move keyboard drivers to driver model Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 01/28] dm: input: Create a keyboard uclass Simon Glass
2015-09-09 12:17 ` Marek Vasut [this message]
2015-09-15 6:11 ` Bin Meng
2015-10-18 23:17 ` Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 02/28] input: Add a device pointer to the input config Simon Glass
2015-09-15 6:11 ` Bin Meng
2015-09-09 4:32 ` [U-Boot] [PATCH 03/28] input: Return -ENOSPC when there is not space Simon Glass
2015-09-15 6:11 ` Bin Meng
2015-09-09 4:32 ` [U-Boot] [PATCH 04/28] input: Add the keycode translation tables separately Simon Glass
2015-09-15 6:11 ` Bin Meng
2015-10-18 23:17 ` Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 05/28] cros_ec: Use udevice instead of cros_ec_dev for keyboard functions Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 06/28] dm: stdio: Plumb in the new keyboard uclass Simon Glass
2015-09-15 6:11 ` Bin Meng
2015-10-18 23:17 ` Simon Glass
2015-10-30 20:24 ` Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 07/28] dm: tegra: Convert keyboard driver to driver model Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 08/28] dm: cros_ec: Convert cros_ec " Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 09/28] video: Drop unused console functions Simon Glass
2015-09-15 6:11 ` Bin Meng
2015-10-18 23:17 ` Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 10/28] i8042: Use functions to handle register access Simon Glass
2015-09-15 6:12 ` Bin Meng
2015-09-09 4:32 ` [U-Boot] [PATCH 11/28] i8042: Handle a duplicate power-on-reset response Simon Glass
2015-09-15 6:12 ` Bin Meng
2015-09-09 4:32 ` [U-Boot] [PATCH 12/28] i8042: Adjust kbd_reset() to collect all failures Simon Glass
2015-09-15 6:12 ` Bin Meng
2015-09-09 4:32 ` [U-Boot] [PATCH 13/28] i8042: Adjust keyboard init to assume success Simon Glass
2015-09-15 6:12 ` Bin Meng
2015-09-09 4:32 ` [U-Boot] [PATCH 14/28] input: Correct keycode for Ctrl-Y Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 15/28] input: Add a few more keyboard keycodes Simon Glass
2015-09-15 6:12 ` Bin Meng
2015-09-09 4:32 ` [U-Boot] [PATCH 16/28] input: Add a function to add a keycode to the existing set Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 17/28] input: Allow repeat filtering to be disabled Simon Glass
2015-10-30 20:24 ` Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 18/28] input: Support the German keymap Simon Glass
2015-09-15 6:12 ` Bin Meng
2015-10-18 23:17 ` Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 19/28] input: Adjust structure of code in process_modifier() Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 20/28] input: Handle caps lock Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 21/28] input: Allow updating of keyboard LEDs Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 22/28] input: i8042: Convert to use the input library Simon Glass
2015-09-15 6:12 ` Bin Meng
2015-09-09 4:32 ` [U-Boot] [PATCH 23/28] input: Add a Kconfig option for the i8042 keyboard Simon Glass
2015-09-15 6:12 ` Bin Meng
2015-09-09 4:32 ` [U-Boot] [PATCH 24/28] x86: Add an i8042 device for boards that have it Simon Glass
2015-09-15 6:12 ` Bin Meng
2015-10-18 23:17 ` Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 25/28] Drop CONFIG_ISA_KEYBOARD Simon Glass
2015-09-15 6:12 ` Bin Meng
2015-09-09 4:32 ` [U-Boot] [PATCH 26/28] input: Convert i8042 to driver model Simon Glass
2015-09-15 6:12 ` Bin Meng
2015-10-18 23:17 ` Simon Glass
2015-10-19 1:53 ` Simon Glass
2015-10-19 3:01 ` Bin Meng
2015-10-19 3:07 ` Simon Glass
2015-09-09 4:32 ` [U-Boot] [PATCH 27/28] video: input: Clean up after i8042 conversion Simon Glass
2015-09-15 6:12 ` Bin Meng
2015-09-09 4:32 ` [U-Boot] [PATCH 28/28] input: Convert 'keyboard' driver to use input library Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201509091417.11168.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox