public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ARM: cache: drop the empty dcache functions as we have it in lib/cache.c
Date: Sat, 12 Sep 2015 11:14:18 +0200	[thread overview]
Message-ID: <20150912111418.367ebc2e@lilith> (raw)
In-Reply-To: <1434000106-5993-2-git-send-email-josh.wu@atmel.com>

Hello Josh,

Sorry this series somehow dropped off my radar completely. Is it still
needed now? If it does, then it would require rework as some of the
functions removed are not empty anymore.

On Thu, 11 Jun 2015 13:21:45 +0800, Josh Wu <josh.wu@atmel.com>
wrote:
> As there are empty function invalidate_dcache_range(), flush_dcache_range()
> in arch/arm/lib/cache.c. So we can reuse it by just drop them in arch/arm/cpu/.
> 
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
> 
>  arch/arm/cpu/arm1136/cpu.c     | 8 --------
>  arch/arm/cpu/arm926ejs/cache.c | 8 --------
>  arch/arm/cpu/armv7/cache_v7.c  | 8 --------
>  arch/arm/cpu/armv8/cache_v8.c  | 8 --------
>  4 files changed, 32 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm1136/cpu.c b/arch/arm/cpu/arm1136/cpu.c
> index a7aed4b..b4d1d54 100644
> --- a/arch/arm/cpu/arm1136/cpu.c
> +++ b/arch/arm/cpu/arm1136/cpu.c
> @@ -134,14 +134,6 @@ void flush_dcache_all(void)
>  {
>  }
>  
> -void invalidate_dcache_range(unsigned long start, unsigned long stop)
> -{
> -}
> -
> -void flush_dcache_range(unsigned long start, unsigned long stop)
> -{
> -}
> -
>  void flush_cache(unsigned long start, unsigned long size)
>  {
>  }
> diff --git a/arch/arm/cpu/arm926ejs/cache.c b/arch/arm/cpu/arm926ejs/cache.c
> index 8d7873c..99d1a13 100644
> --- a/arch/arm/cpu/arm926ejs/cache.c
> +++ b/arch/arm/cpu/arm926ejs/cache.c
> @@ -83,14 +83,6 @@ void flush_dcache_all(void)
>  {
>  }
>  
> -void invalidate_dcache_range(unsigned long start, unsigned long stop)
> -{
> -}
> -
> -void flush_dcache_range(unsigned long start, unsigned long stop)
> -{
> -}
> -
>  void flush_cache(unsigned long start, unsigned long size)
>  {
>  }
> diff --git a/arch/arm/cpu/armv7/cache_v7.c b/arch/arm/cpu/armv7/cache_v7.c
> index e8ee875..4f0e406 100644
> --- a/arch/arm/cpu/armv7/cache_v7.c
> +++ b/arch/arm/cpu/armv7/cache_v7.c
> @@ -304,14 +304,6 @@ void flush_dcache_all(void)
>  {
>  }
>  
> -void invalidate_dcache_range(unsigned long start, unsigned long stop)
> -{
> -}
> -
> -void flush_dcache_range(unsigned long start, unsigned long stop)
> -{
> -}
> -
>  void arm_init_before_mmu(void)
>  {
>  }
> diff --git a/arch/arm/cpu/armv8/cache_v8.c b/arch/arm/cpu/armv8/cache_v8.c
> index c5ec529..f8c17cc 100644
> --- a/arch/arm/cpu/armv8/cache_v8.c
> +++ b/arch/arm/cpu/armv8/cache_v8.c
> @@ -149,14 +149,6 @@ void flush_dcache_all(void)
>  {
>  }
>  
> -void invalidate_dcache_range(unsigned long start, unsigned long stop)
> -{
> -}
> -
> -void flush_dcache_range(unsigned long start, unsigned long stop)
> -{
> -}
> -
>  void dcache_enable(void)
>  {
>  }
> -- 
> 1.9.1
> 



Amicalement,
-- 
Albert.

  reply	other threads:[~2015-09-12  9:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05  7:47 [U-Boot] [PATCH v2 1/3] ARM: cache: add an empty stub function for invalidate/flush dcache Josh Wu
2015-06-05  7:47 ` [U-Boot] [PATCH v2 2/3] m68k: cache: add an empty stub functions " Josh Wu
2015-06-05 21:29   ` Angelo Dureghello
2015-06-05  7:47 ` [U-Boot] [PATCH v2 3/3] usb: ohci: enable cache support Josh Wu
2015-06-05 13:18 ` [U-Boot] [PATCH v2 1/3] ARM: cache: add an empty stub function for invalidate/flush dcache Marek Vasut
2015-06-08  2:05   ` Josh Wu
2015-06-08  8:26     ` Marek Vasut
2015-06-08  9:15       ` Josh Wu
2015-06-08 13:20       ` Tom Rini
2015-06-09  3:54         ` Josh Wu
2015-06-09 13:11           ` Tom Rini
2015-06-10  9:49             ` Josh Wu
2015-06-10  9:58               ` Marek Vasut
2015-06-11  5:03                 ` Josh Wu
2015-06-10 18:20               ` Tom Rini
2015-06-11  5:21 ` [U-Boot] [resend][PATCH 0/2] ARM: cache: clean up the code to drop the empty stub functions Josh Wu
2015-06-11  5:21   ` [U-Boot] [PATCH 1/2] ARM: cache: drop the empty dcache functions as we have it in lib/cache.c Josh Wu
2015-09-12  9:14     ` Albert ARIBAUD [this message]
2015-09-12 13:17       ` Tom Rini
2015-06-11  5:21   ` [U-Boot] [PATCH 2/2] ARM: cache: implement a default flush_cache() function Josh Wu
2015-07-01  2:01   ` [U-Boot] [resend][PATCH 0/2] ARM: cache: clean up the code to drop the empty stub functions Josh Wu
  -- strict thread matches above, loose matches on Subject: below --
2015-06-11  4:19 [U-Boot] [PATCH " Josh Wu
2015-06-11  4:19 ` [U-Boot] [PATCH 1/2] ARM: cache: drop the empty dcache functions as we have it in lib/cache.c Josh Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150912111418.367ebc2e@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox