From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: ci_udc: fix emissions of ZLPs
Date: Sat, 12 Sep 2015 20:26:42 +0200 [thread overview]
Message-ID: <201509122026.42619.marex@denx.de> (raw)
In-Reply-To: <1442013002-1136-1-git-send-email-swarren@wwwdotorg.org>
On Saturday, September 12, 2015 at 01:10:02 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Commit 6a132416359e "ci_udc: Update the ci_udc driver to support bulk
> transfers" caused the value of "len" to change without updating subsquent
> users of that variable in ci_ep_submit_next_request(). This caused the
> code that detects when to emit ZLPs (Zero Length Packets) never to
> trigger, which in turn caused host timeouts when a ZLP was required,
> which in turn broke tests/dfu/, even despite the assertion in that
> commit's description that "These changes are tested for both the DFU and
> lthor."
>
> Fix this by modifying the added dtd iteration code not to modify "len",
> but rather to keep state in a separate variable. Rename the variables
> while we're at it so they describe their purpose better.
>
> Fixes: 6a132416359e ("ci_udc: Update the ci_udc driver to support bulk
> transfers") Cc: Siva Durga Prasad Paladugu
> <siva.durga.paladugu@xilinx.com>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Applied, thanks!
Best regards,
Marek Vasut
prev parent reply other threads:[~2015-09-12 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 23:10 [U-Boot] [PATCH] usb: ci_udc: fix emissions of ZLPs Stephen Warren
2015-09-12 18:26 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201509122026.42619.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox