From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sat, 12 Sep 2015 20:26:42 +0200 Subject: [U-Boot] [PATCH] usb: ci_udc: fix emissions of ZLPs In-Reply-To: <1442013002-1136-1-git-send-email-swarren@wwwdotorg.org> References: <1442013002-1136-1-git-send-email-swarren@wwwdotorg.org> Message-ID: <201509122026.42619.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday, September 12, 2015 at 01:10:02 AM, Stephen Warren wrote: > From: Stephen Warren > > Commit 6a132416359e "ci_udc: Update the ci_udc driver to support bulk > transfers" caused the value of "len" to change without updating subsquent > users of that variable in ci_ep_submit_next_request(). This caused the > code that detects when to emit ZLPs (Zero Length Packets) never to > trigger, which in turn caused host timeouts when a ZLP was required, > which in turn broke tests/dfu/, even despite the assertion in that > commit's description that "These changes are tested for both the DFU and > lthor." > > Fix this by modifying the added dtd iteration code not to modify "len", > but rather to keep state in a separate variable. Rename the variables > while we're at it so they describe their purpose better. > > Fixes: 6a132416359e ("ci_udc: Update the ci_udc driver to support bulk > transfers") Cc: Siva Durga Prasad Paladugu > > Signed-off-by: Stephen Warren Applied, thanks! Best regards, Marek Vasut