public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peng Fan <b51431@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] imx: wdog: correct wcr register settings
Date: Mon, 14 Sep 2015 19:46:28 +0800	[thread overview]
Message-ID: <20150914114624.GA9702@shlinux2> (raw)
In-Reply-To: <CAOMZO5DQF35RsqdM5DOQ3Fp95Zmq=ERxr2O_2r9+x2tnAh5fWg@mail.gmail.com>

On Mon, Sep 14, 2015 at 09:11:30AM -0300, Fabio Estevam wrote:
>On Mon, Sep 14, 2015 at 2:34 AM, Peng Fan <Peng.Fan@freescale.com> wrote:
>> We should not simple use "writew(WCR_WDE, &wdog->wcr)" to set
>> wcr, since this will override bits set before reset_cpu.
>>
>> Use clrsetbits_le32 instead of writew to fix this issue.
>
>There is a typo here: it should be clrsetbits_le16.

Fabio, thanks for pointing this out.

Stefano, can you help fix this when you plan to apply this patch?
Or do you need to send v2 to fix this commit log typo?

Thanks,
Peng.
-- 

  reply	other threads:[~2015-09-14 11:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14  5:34 [U-Boot] [PATCH 1/3] imx-common: fix iomux settings Peng Fan
2015-09-14  5:34 ` [U-Boot] [PATCH 2/3] imx: wdog: correct wcr register settings Peng Fan
2015-09-14 12:09   ` Fabio Estevam
2015-09-14 12:11   ` Fabio Estevam
2015-09-14 11:46     ` Peng Fan [this message]
2015-09-20  7:42     ` Stefano Babic
2015-09-14  5:34 ` [U-Boot] [PATCH 3/3] imx: mx7dsabresd set wdog SRS bit Peng Fan
2015-09-14 12:09   ` Fabio Estevam
2015-09-14 12:08 ` [U-Boot] [PATCH 1/3] imx-common: fix iomux settings Fabio Estevam
2015-09-20  7:43 ` Stefano Babic
2015-09-20 11:33   ` Benoît Thébaudeau
2015-09-20 13:02     ` Peng Fan
2015-09-20 14:57       ` Stefano Babic
2015-09-20 15:02       ` Benoît Thébaudeau
2015-09-21  1:05         ` Peng Fan
2015-09-21 18:41           ` Benoît Thébaudeau
2015-09-21 20:13             ` Stefano Babic
2015-09-22  0:36               ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150914114624.GA9702@shlinux2 \
    --to=b51431@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox