From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Mon, 14 Sep 2015 19:46:28 +0800 Subject: [U-Boot] [PATCH 2/3] imx: wdog: correct wcr register settings In-Reply-To: References: <1442208885-32387-1-git-send-email-Peng.Fan@freescale.com> <1442208885-32387-2-git-send-email-Peng.Fan@freescale.com> Message-ID: <20150914114624.GA9702@shlinux2> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Sep 14, 2015 at 09:11:30AM -0300, Fabio Estevam wrote: >On Mon, Sep 14, 2015 at 2:34 AM, Peng Fan wrote: >> We should not simple use "writew(WCR_WDE, &wdog->wcr)" to set >> wcr, since this will override bits set before reset_cpu. >> >> Use clrsetbits_le32 instead of writew to fix this issue. > >There is a typo here: it should be clrsetbits_le16. Fabio, thanks for pointing this out. Stefano, can you help fix this when you plan to apply this patch? Or do you need to send v2 to fix this commit log typo? Thanks, Peng. --