From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] mtd: nand: fsmc: Fixes and cleanup for fsmc_nand_switch_ecc()
Date: Tue, 15 Sep 2015 17:34:17 -0400 [thread overview]
Message-ID: <20150915213417.GP26226@bill-the-cat> (raw)
In-Reply-To: <1442213267-9343-1-git-send-email-sr@denx.de>
On Mon, Sep 14, 2015 at 08:47:47AM +0200, Stefan Roese wrote:
> This patch addresses some comments raised by Scott in the last versions.
> Here the changes in detail:
>
> - Removed __maybe_unused as its not needed
> - Added check for strength == 4 and error out for the unsupported
> ECC strength values
> - Don't set .caclulate, .correct, and .bytes for NAND_ECC_SOFT_BCH as this
> will be done in nand_scan_tail()
> - Set .caclulate back to fsmc_read_hwecc() in the HW case
> - Added comment that this function will only be called on SPEAr platforms,
> not supporting the BCH8 HW ECC (FSMC_VER8)
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Tom Rini <trini@konsulko.com>
> Acked-by: Scott Wood <scottwood@freescale.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150915/eef97b90/attachment.sig>
prev parent reply other threads:[~2015-09-15 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 6:47 [U-Boot] [PATCH] mtd: nand: fsmc: Fixes and cleanup for fsmc_nand_switch_ecc() Stefan Roese
2015-09-14 15:17 ` Scott Wood
2015-09-15 21:34 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915213417.GP26226@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox