[U-Boot] [PATCH] ARM: socfpga: Enable saveenv for SD/MMC

[Marek Vasut <marex@denx.de>]

On Tuesday, September 15, 2015 at 09:47:23 PM, dinguyen at opensource.altera.com 
wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
> 
> Enable the able to save the environment variables when SD/MMC is used.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>

Hi,

this should be done per-board, so I'd suggest the following:
1) Rename include/configs/socfpga_cyclone5.h to socfpga_cyclone5_socdk.h
   (to make it in-line with the naming in boards/altera/ , sorry, I forgot
    about this bit :( You'd also have to fix the MAINTAINERS file to match
    the adjusted filename).
2) Rename socfpga_arria5.h to socfpga_arria5_socdk.h
3) Enable this for both boards in socfpga_*_socdk.h

Can you do that please ?

Thanks!

> ---
>  include/configs/socfpga_common.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/configs/socfpga_common.h
> b/include/configs/socfpga_common.h index 38ae763..f6a79ad 100644
> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -160,6 +160,9 @@
>  /* FIXME */
>  /* using smaller max blk cnt to avoid flooding the limited stack we have
> */ #define CONFIG_SYS_MMC_MAX_BLK_COUNT	256	/* FIXME -- SPL only? */
> +#define CONFIG_ENV_IS_IN_MMC
> +#define CONFIG_SYS_MMC_ENV_DEV		0	/* device 0 */
> +#define CONFIG_ENV_OFFSET		512	/* just after the MBR */
>  #endif
> 
>  /*
> @@ -282,7 +285,9 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
>  #define CONFIG_SYS_CONSOLE_IS_IN_ENV
>  #define CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE
>  #define CONFIG_SYS_CONSOLE_ENV_OVERWRITE
> +#if !defined CONFIG_ENV_IS_IN_MMC
>  #define CONFIG_ENV_IS_NOWHERE
> +#endif
>  #define CONFIG_ENV_SIZE			4096
> 
>  /*

Best regards,
Marek Vasut