public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: socfpga: Enable saveenv for SD/MMC
Date: Wed, 16 Sep 2015 08:57:16 +0200	[thread overview]
Message-ID: <20150916065716.GB11562@amd> (raw)
In-Reply-To: <201509152222.33768.marex@denx.de>

On Tue 2015-09-15 22:22:33, Marek Vasut wrote:
> On Tuesday, September 15, 2015 at 09:47:23 PM, dinguyen at opensource.altera.com 
> wrote:
> > From: Dinh Nguyen <dinguyen@opensource.altera.com>
> > 
> > Enable the able to save the environment variables when SD/MMC is used.
> > 
> > Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> 
> Hi,
> 
> this should be done per-board, so I'd suggest the following:

Why? MMC layout is same on all of them...

> >  #define CONFIG_ENV_SIZE			4096

While you are changing that, bigger environment size would be
welcome. 32K?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2015-09-16  6:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15 19:47 [U-Boot] [PATCH] ARM: socfpga: Enable saveenv for SD/MMC dinguyen at opensource.altera.com
2015-09-15 20:22 ` Marek Vasut
2015-09-15 21:48   ` Dinh Nguyen
2015-09-15 22:48     ` Marek Vasut
2015-09-16  6:57   ` Pavel Machek [this message]
2015-09-16  6:59     ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150916065716.GB11562@amd \
    --to=pavel@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox