[U-Boot] [PATCH] ARM: socfpga: Enable saveenv for SD/MMC

Stefan Roese
2015-09-16T06:59:50Z

On 16.09.2015 08:57, Pavel Machek wrote:
> On Tue 2015-09-15 22:22:33, Marek Vasut wrote:
>> On Tuesday, September 15, 2015 at 09:47:23 PM, dinguyen at opensource.altera.com
>> wrote:
>>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>>>
>>> Enable the able to save the environment variables when SD/MMC is used.
>>>
>>> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
>>
>> Hi,
>>
>> this should be done per-board, so I'd suggest the following:
>
> Why? MMC layout is same on all of them...

It doesn't have to be identical. And other boards might want to use e.g.
SPI NOR as the environment storage device (I have such a custom board
here). So this is definitely a board specific thing.

>>> #define CONFIG_ENV_SIZE 4096
>
> While you are changing that, bigger environment size would be
> welcome. 32K?

Yes.

Thanks,
Stefan