From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Date: Wed, 16 Sep 2015 18:47:30 -0500 Subject: [U-Boot] [PATCH V2 1/4] drivers: Introduce a simplified remoteproc framework In-Reply-To: References: <1440734853-6552-1-git-send-email-nm@ti.com> <1440734853-6552-2-git-send-email-nm@ti.com> Message-ID: <20150916234729.GA30118@ogun.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 21:46-20150901, Simon Glass wrote: Hi Simon, Apologies on a delayed response. [...] > > Changes in V2: > > - review comments incorporated from v1 > > Ah yes, but which ones?! Hopefully all of them - I'd normally list up the details, but the changes were a little too many in the case of v2.. [...] > > > [snip] > > Reviewed-by: Simon Glass Thanks. Will post next rev fixing the nits and picking up your reviewed-by tag. > > A few nits below. Thanks once again for your patience and review. > > + > > +/* > > + * XXX XXX XXX > > + * *IMPORTANT* NOTE: THE PLATFORM DATA SUPPORT IS NOT MEANT FOR USE WITH NEWER > > + * PLATFORMS. THIS IS MEANT ONLY FOR LEGACY DEVICES. THIS MODE OF > > + * INITIALIZATION *WILL* BE EVENTUALLY REMOVED ONCE ALL NECESSARY > > + * PLATFORMS HAVE MOVED TO DM/FDT. > > + * XXX XXX XXX > > + */ > > This can be lower case and you should remove the XXXX stuff. Will do so in the next rev. > > +/* Accessor */ > > +#define rproc_get_ops(dev) ((struct dm_rproc_ops *)(dev)->driver->ops) > > + > > +#ifdef CONFIG_REMOTEPROC > > +int rproc_init(void); > > +bool rproc_is_initialized(void); > > +int rproc_load(int id, ulong addr, ulong size); > > +int rproc_start(int id); > > +int rproc_stop(int id); > > +int rproc_reset(int id); > > +int rproc_ping(int id); > > +int rproc_is_running(int id); > > Can you move your function comments to here? This where you define > your API, and it is the file that people will read. Will do so as well. -- Regards, Nishanth Menon