From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dfu: dfu_sf: Take the start address into account
Date: Wed, 23 Sep 2015 10:09:19 +0200 [thread overview]
Message-ID: <20150923100919.30e977ff@amdc2363> (raw)
In-Reply-To: <1442980239-3931-1-git-send-email-festevam@gmail.com>
Hi Fabio,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> The dfu_alt_info_spl variable allows passing a starting point
> for the binary to be flashed in the SPI NOR.
>
> For example, if we have 'dfu_alt_info_spl=spl raw 0x400', this means
> that we want to flash the binary starting at address 0x400.
>
> In order to do so we need to erase the entire sector and write to
> the the subsequent SPI NOR sectors taking such start address
> into account for the address calculations.
>
> Tested by succesfully writing SPL binary into 0x400 offset and
> the u-boot.img at offset 64 kiB of a SPL NOR.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/dfu/dfu_sf.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c
> index 448d95d..844da1f 100644
> --- a/drivers/dfu/dfu_sf.c
> +++ b/drivers/dfu/dfu_sf.c
> @@ -23,17 +23,25 @@ static int dfu_read_medium_sf(struct dfu_entity
> *dfu, u64 offset, void *buf, return spi_flash_read(dfu->data.sf.dev,
> offset, *len, buf); }
>
> +static u64 find_sector(struct dfu_entity *dfu, u64 start, u64 offset)
> +{
> + return ((start + offset) / dfu->data.sf.dev->sector_size) *
> + dfu->data.sf.dev->sector_size;
> +}
> +
> static int dfu_write_medium_sf(struct dfu_entity *dfu,
> u64 offset, void *buf, long *len)
> {
> int ret;
>
> - ret = spi_flash_erase(dfu->data.sf.dev, offset,
> + ret = spi_flash_erase(dfu->data.sf.dev,
> + find_sector(dfu, dfu->data.sf.start,
> offset), dfu->data.sf.dev->sector_size);
> if (ret)
> return ret;
>
> - ret = spi_flash_write(dfu->data.sf.dev, offset, *len, buf);
> + ret = spi_flash_write(dfu->data.sf.dev, dfu->data.sf.start +
> offset,
> + *len, buf);
> if (ret)
> return ret;
>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Applied to u-boot-dfu.
Thanks for your patch.
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2015-09-23 8:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 3:50 [U-Boot] [PATCH] dfu: dfu_sf: Take the start address into account Fabio Estevam
2015-09-23 8:09 ` Lukasz Majewski [this message]
2015-09-23 15:22 ` Stephen Warren
2015-09-23 15:36 ` Fabio Estevam
2015-09-23 15:44 ` Fabio Estevam
2015-09-23 15:53 ` Stephen Warren
2015-10-20 0:06 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923100919.30e977ff@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox