public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] exynos: be more verbose in process_nodes()
Date: Wed, 23 Sep 2015 11:41:54 +0200	[thread overview]
Message-ID: <20150923114154.7c0c551c@amdc2363> (raw)
In-Reply-To: <1442793252-2935-1-git-send-email-tjakobi@math.uni-bielefeld.de>

Hi Tobias,

> +		ret = sdhci_get_config(blob, node, host);
> +		if (ret) {
> +			printf("%s: failed to decode dev %d (%d)\n",
> __func__, i, ret); return -1;

My only commit here is regarding leaving return -1 as it is now. I
think, that it would be better to return ret.

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

      parent reply	other threads:[~2015-09-23  9:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-20 23:54 [U-Boot] [PATCH 3/4] exynos: be more verbose in process_nodes() Tobias Jakobi
2015-09-20 23:54 ` [U-Boot] [PATCH 4/4] exynos: fix and cleanup do_sdhci_init() Tobias Jakobi
2015-09-23  9:44   ` Lukasz Majewski
2015-09-23  9:48     ` Lukasz Majewski
2015-09-23  9:59       ` Jaehoon Chung
2015-09-23 10:06         ` Lukasz Majewski
2015-09-23 10:06         ` Minkyu Kang
2015-09-24 12:48           ` Tobias Jakobi
2015-09-24 13:27             ` Lukasz Majewski
2015-09-24 15:05   ` Przemyslaw Marczak
2015-09-23  9:41 ` Lukasz Majewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150923114154.7c0c551c@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox