From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Thu, 24 Sep 2015 09:22:03 +0200
Subject: [U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base
	configuration in init
In-Reply-To: <1443053976-9112-2-git-send-email-vikas.manocha@st.com>
References: <1443053976-9112-1-git-send-email-vikas.manocha@st.com>
 <1443053976-9112-2-git-send-email-vikas.manocha@st.com>
Message-ID: <20150924072203.81D11380DF2@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Vikas,

In message <1443053976-9112-2-git-send-email-vikas.manocha@st.com> you wrote:
> No need to configure indirect trigger address for every read/write.
...
>  	/* Indirect mode configurations */
>  	writel((plat->sram_size/2), plat->regbase + CQSPI_REG_SRAMPARTITION);
> +	writel((u32)plat->ahbbase & CQSPI_INDIRECTTRIGGER_ADDR_MASK,
> +	       plat->regbase + CQSPI_REG_INDIRECTTRIGGER);

I did not mention this explicitly, so I do it here:

Please fix this type cast issue globally, in all your patches.
Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Marriage is like a cage; one sees the birds outside desperate to get
in, and those inside desperate to get out."               - Montaigne