From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 04/11] vexpress64: Kconfig: add CONFIG_SYS_BOOTM_LEN
Date: Mon, 28 Sep 2015 11:13:02 -0400 [thread overview]
Message-ID: <20150928151302.GI22966@bill-the-cat> (raw)
In-Reply-To: <1443029143-22313-5-git-send-email-ryan.harkin@linaro.org>
On Wed, Sep 23, 2015 at 10:25:36AM -0700, Ryan Harkin wrote:
> vexpress64 kernels are usually over 8 MBytes in length, so setting the
> max uImage length to 0x4000000 (64 Mbytes) should give us plenty of
> scope for expansion.
>
> I mostly chose this length to match other board configs that use
> "(64 << 20)", however, Kconfig doesn't allow arithmetic operations.
>
> Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> CC: Masahiro Yamada <yamada.m@jp.panasonic.com
> CC: Linus Walleij <linus.walleij@linaro.org>
> ---
> board/armltd/vexpress64/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/board/armltd/vexpress64/Kconfig b/board/armltd/vexpress64/Kconfig
> index 8da3bec..72679be 100644
> --- a/board/armltd/vexpress64/Kconfig
> +++ b/board/armltd/vexpress64/Kconfig
> @@ -1,3 +1,6 @@
> +config CONFIG_SYS_BOOTM_LEN
> + default 0x4000000
> +
> config SYS_BOARD
> default "vexpress64"
First, this is a typo (should be SYS_BOOTM_LEN, not
CONFIG_SYS_BOOTM_LEN) and second, this sounds more like it should be set
as the default for say aarch64 when adding the option to Kconfig. Or
maybe a more broad default even. moveconfig.py will help make it
clearer how many boards use what.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150928/689862cf/attachment.sig>
next prev parent reply other threads:[~2015-09-28 15:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 17:25 [U-Boot] [PATCH 00/11] vexpress64 FVP and Juno configuration updates Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 01/11] vexpress64: fix checkpatch warnings Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 02/11] vexpress64: Kconfig: tidy up Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 03/11] Kconfig: add CONFIG_SYS_BOOTM_LEN Ryan Harkin
2015-09-28 15:10 ` Tom Rini
2015-09-28 15:35 ` Ryan Harkin
2015-09-28 16:03 ` Tom Rini
2015-09-28 19:22 ` Hans de Goede
2015-09-28 21:12 ` Tom Rini
2015-09-29 8:38 ` Hans de Goede
2015-09-23 17:25 ` [U-Boot] [PATCH 04/11] vexpress64: " Ryan Harkin
2015-09-28 15:13 ` Tom Rini [this message]
2015-09-23 17:25 ` [U-Boot] [PATCH 05/11] vexpress64: fvp dram: add DRAM configuration Ryan Harkin
2015-09-28 15:14 ` Tom Rini
2015-09-28 15:27 ` Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 06/11] vexpress64: juno: add androidboot.hardware=juno Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 07/11] common/armflash: add command to check if image exists Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 08/11] common/armflash: load_image returns success or failure Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 09/11] vexpress64: juno: add optional initrd Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 10/11] vexpress64: juno: add alternate kernel and device tree filenames Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 11/11] vexpress64: juno: use /dev/sda2 Ryan Harkin
2015-09-23 17:35 ` [U-Boot] [PATCH 00/11] vexpress64 FVP and Juno configuration updates Ryan Harkin
2015-09-24 16:33 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928151302.GI22966@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox