From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 28 Sep 2015 12:03:12 -0400 Subject: [U-Boot] [PATCH 03/11] Kconfig: add CONFIG_SYS_BOOTM_LEN In-Reply-To: References: <1443029143-22313-1-git-send-email-ryan.harkin@linaro.org> <1443029143-22313-4-git-send-email-ryan.harkin@linaro.org> <20150928151053.GH22966@bill-the-cat> Message-ID: <20150928160312.GL22966@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Sep 28, 2015 at 04:35:09PM +0100, Ryan Harkin wrote: > Thanks Tom. > > On 28 September 2015 at 16:10, Tom Rini wrote: > > > On Wed, Sep 23, 2015 at 10:25:35AM -0700, Ryan Harkin wrote: > > > > > As config migrates from board config files to Kconfig, when adding > > > CONFIG_SYS_BOOTM_LEN to a platform, I decided to add > > > Kconfig support for CONFIG_SYS_BOOTM_LEN. > > > > > > Signed-off-by: Ryan Harkin > > > Reviewed-by: Linus Walleij > > > CC: Masahiro Yamada > > > CC: Simon Glass > > > CC: Linus Walleij > > > > Thanks for trying to do this. The problem however is that you need to > > use tools/moveconfig.py so that all of the other boards (which is a lot) > > get updated too, otherwise they fail to build. > > > > Yes, I just read another email on the list about using moveconfig.py. > That's a big job, as you say. > > > > Since that's kind of a big thing, can you split this series into a v2 of > > things which really should be in before the release, and then nice > > cleanups like this which can go in once the merge window is open again? > > Thanks! > > > > So I should post a v2 that uses CONFIG_SYS_BOOTM_LEN like all the other > boards for now? Then submit a new series to use moveconfig.py to Kconfig? Yeah, for this release at least. > I already tried using moveconfig.py for this and it fails on every > instance, from what I can tell. I think the other board configs using the > shift operation makes this tricky. > > I guess there are two options: make Kconfig support complex values (eg. to > allow << operators, etc.) or convert all the other boards to use absolute > values. Of course, another option is to leave it alone. Well, if you can convince the Kconfig folks to take shift operations as valid values on numeric inputs I bet other projects would appreciate it. But it might be easier to start with a "simple" script that finds all of the configs that define it to a shifted value and use printf to convert it to hex. Then moveconfig.py should be able to convert. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: