U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 05/10] ti: omap3: config: remove 1 from boolean define
Date: Tue, 29 Sep 2015 13:12:32 -0400	[thread overview]
Message-ID: <20150929171232.GK22966@bill-the-cat> (raw)
In-Reply-To: <560ABB77.8090206@compulab.co.il>

On Tue, Sep 29, 2015 at 07:25:27PM +0300, Igor Grinberg wrote:

> ping
> 
> On 09/24/15 12:56, Igor Grinberg wrote:
> > Hi Tom,
> > 
> > On 08/26/15 17:54, Igor Grinberg wrote:
> >> CONFIG_TWL4030_POWER is a boolean define variable. It is either defined
> >> or not defined and should not have a value assigned to it.
> >> Remove the value.
> >>
> >> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> > 
> > I think this one can also be applied, no?
> > 
> >> ---
> >>  include/configs/ti_omap3_common.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/include/configs/ti_omap3_common.h b/include/configs/ti_omap3_common.h
> >> index be231a5..e399a87 100644
> >> --- a/include/configs/ti_omap3_common.h
> >> +++ b/include/configs/ti_omap3_common.h
> >> @@ -66,7 +66,7 @@
> >>  #define CONFIG_SYS_MONITOR_LEN		(256 << 10)
> >>  
> >>  /* TWL4030 */
> >> -#define CONFIG_TWL4030_POWER		1
> >> +#define CONFIG_TWL4030_POWER
> >>  
> >>  /* SPL */
> >>  #define CONFIG_SPL_TEXT_BASE		0x40200800

Reviewed-by: Tom Rini <trini@konsulko.com>

And I figured you just re-post this as part of v2 as it's trivially
correct but also a tiny thing in a bigger series.
-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150929/b35fd2a4/attachment.sig>

  reply	other threads:[~2015-09-29 17:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-26 14:54 [U-Boot] [PATCH 00/10] Kconfig and ti omap configs tidy up Igor Grinberg
2015-08-26 14:54 ` [U-Boot] [PATCH 01/10] configs: remove remnants of CONFIG_SYS_NAND_QUIET_TEST Igor Grinberg
2015-08-27  4:53   ` Stefan Roese
2015-09-28 21:07   ` [U-Boot] [U-Boot, " Tom Rini
2015-08-26 14:54 ` [U-Boot] [PATCH 02/10] Kconfig: fix typo in CONFIG_FIT description Igor Grinberg
2015-08-28 17:58   ` Simon Glass
2015-09-28 21:07   ` [U-Boot] [U-Boot, " Tom Rini
2015-08-26 14:54 ` [U-Boot] [PATCH 03/10] Kconfig: add CONFIG_BOOTDELAY Igor Grinberg
2015-08-28 17:58   ` Simon Glass
2015-08-26 14:54 ` [U-Boot] [PATCH 04/10] Kconfig: add CONFIG_CMD_BOOTZ Igor Grinberg
2015-09-24  9:57   ` Igor Grinberg
2015-09-29 16:25     ` Igor Grinberg
2015-09-29 17:11       ` Tom Rini
2015-09-30  7:52         ` Igor Grinberg
2015-08-26 14:54 ` [U-Boot] [PATCH 05/10] ti: omap3: config: remove 1 from boolean define Igor Grinberg
2015-09-24  9:56   ` Igor Grinberg
2015-09-29 16:25     ` Igor Grinberg
2015-09-29 17:12       ` Tom Rini [this message]
2015-09-30  7:54         ` Igor Grinberg
2015-08-26 14:54 ` [U-Boot] [PATCH 06/10] ti: omap/am: move CONFIG_HUSH_PARSER to defconfig Igor Grinberg
2015-08-26 14:54 ` [U-Boot] [PATCH 07/10] ti: omap/am: move CONFIG_CMD_BOOTZ " Igor Grinberg
2015-08-26 14:54 ` [U-Boot] [PATCH 08/10] ti: omap/am: move CONFIG_CMD_NAND " Igor Grinberg
2015-08-26 14:54 ` [U-Boot] [PATCH 09/10] ti: omap/am: move CONFIG_CMD_I2C " Igor Grinberg
2015-08-26 14:54 ` [U-Boot] [PATCH 10/10] ti: omap/am: move CONFIG_BOOTDELAY " Igor Grinberg
2015-09-24  9:53 ` [U-Boot] [PATCH 00/10] Kconfig and ti omap configs tidy up Igor Grinberg
2015-09-25 17:37   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150929171232.GK22966@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox