From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "imx: wdog: correct wcr register settings"
Date: Thu, 01 Oct 2015 22:11:43 +0200 [thread overview]
Message-ID: <20151001201143.865D8380905@gemini.denx.de> (raw)
In-Reply-To: <1443727970-10347-1-git-send-email-festevam@gmail.com>
Dear Fabio,
In message <1443727970-10347-1-git-send-email-festevam@gmail.com> you wrote:
>
> Unlike i.MX, LS1021 uses big-endian ordering for the watchdog
> controller, which means we cannot use the little endian accessors.
...
> - clrsetbits_le16(&wdog->wcr, 0, WCR_WDE);
> -
> + writew(WCR_WDE, &wdog->wcr);
I'm sorry, but I fail to understand how writew() can be better than
another I/O accessor. Neither of these has the capability to detect
the endianess of this specific register interface ?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As far as the laws of mathematics refer to reality, they are not cer-
tain, and as far as they are certain, they do not refer to reality.
-- Albert Einstein
next prev parent reply other threads:[~2015-10-01 20:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 19:32 [U-Boot] [PATCH] Revert "imx: wdog: correct wcr register settings" Fabio Estevam
2015-10-01 19:39 ` Sinan Akman
2015-10-01 19:45 ` Fabio Estevam
2015-10-01 19:50 ` Sinan Akman
2015-10-01 19:52 ` Fabio Estevam
2015-10-01 20:11 ` Wolfgang Denk [this message]
2015-10-01 20:19 ` Fabio Estevam
2015-10-01 20:50 ` Wolfgang Denk
2015-10-01 23:11 ` Fabio Estevam
2015-10-02 1:48 ` Sinan Akman
2015-10-02 4:30 ` Wolfgang Denk
2015-10-02 11:10 ` Fabio Estevam
2015-10-02 11:39 ` Fabio Estevam
2015-10-02 13:04 ` Sinan Akman
2015-10-02 13:29 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001201143.865D8380905@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox