From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 08 Oct 2015 23:29:01 +0200 Subject: [U-Boot] Inconsistencies in commands regarding load_addr In-Reply-To: <56167DB6.3000508@wwwdotorg.org> References: <5613E20F.8060306@wsystem.com> <20151008044015.BC4DB380905@gemini.denx.de> <56167DB6.3000508@wwwdotorg.org> Message-ID: <20151008212902.065EE382CD2@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stephen, In message <56167DB6.3000508@wwwdotorg.org> you wrote: > > >> What's the expected correct behavior here? > > > > After successful loading the data to memory, load_addr should be set > > correctly, for all commands. In the error case, the value of > > load_addr is undefined. > > Is this documented anywhere? If not, I'm not convinced that there's a > contract to be followed; it "just happens" that some filesystem-related > commands work(ed) that way (and as Beno?t pointed out, apparently some > don't irrespective of the mentioned patch). I'm afraid it's not documented, but it is what I would consider a sane and consistent behaviour. If we intend to implement POLA [1] (and I very much think we should), this is how U-Boot should behave. [1] https://en.wikipedia.org/wiki/Principle_of_least_astonishment Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de What we hope ever to do with ease, we must learn first to do with diligence. - Samuel Johnson